1521376 - The yellow star used to mark messages is truncated in the right side, missing 1 or 2 pixels

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Cristian]

Attachment: Thunderbird_star.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Hello from Romania. I would like to report following bug. The yellow star used to mark the messages, is truncated in the right side, missing 1 or 2 pixels.

Look very close. Have to enlarge the column a little bit (1 or 2 pixel) to have space enough for the yellow star. Maybe nobody seen yet but looks bad for a professional look and I see it as I use a lot that star to mark messages. Is like unfinished software.

Actual results:

This problem seems was also 10 years in the Bug 439628.

That time was different, the column border cutted the star.

This time, the star is truncated even when the right border is moved on the right side. See picture attached.

Should be a problem about "padding" of the border line (the space from the border line), that space cut the star arm 1 or 2 pixels. Maybe simple fix, move the border line even more 1pixel to the right side, will fix. If is not from the column, then should be from padding on the right side.

Expected results:

The same problem was also in the ver. 50 and now is on the 60 as well. Today I had time to write you about. Please fix it for me.

I use Thunderbird since before 2004, I even don't remember exactly already when I start using it.

Comment 1

[WaltS48 [:walts48]]

What is creating the yellow Menu Bar?

Does the same problem occur in safe mode? Use Help > Restart with Add-ons Disabled.

Comment 2

[Jorg K (CEST = GMT+2)]

The yellow is most likely the Windows accent colour.

Reporter, I can't see anything cut off. Rirchard, can you?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: star.png

This shows it better. The tip on the right is a bit dull.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1521376-move-star.patch

This fixes it.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9037867 [details] [diff] [review]
1521376-move-star.patch

Review of attachment 9037867 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ff32d5c4c737
Move the star icon to the left with a negative margin instead a padding. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

TB 60.5.0 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/acaf08e72ead14783d06d0cd8f14431b31ba3b97

Comment 8

[Cristian]

Hello.
Seems that my post was useful, I'm glad :)
Please send me a printr-screen about how looking fixed.

Thanks,
Cristian

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: star.png

Here you go. Yes, we fixed it and a better star will ship in TB 60.5 at the end of the month.

Comment 10

[Jorg K (CEST = GMT+2)]

TB 65 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/d3ac1b6bf4172c2eab869da1865fc0b4394bbe08