1523048 - Copying a message filter won't copy when the filter is applied

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[orctarorga]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

From the toolbar, click AppMenu(the button with three horizontal bars) -> Message Filters -> Message Filters, to open the Message Filters window.
Create a filter with arbitrary triggering condition and actions, but change the settings on when the filter is applied. In default, Manually Run and Getting New Mail are selected. For example, we can turn on Manually Run on but all others off.
Then copy the filter we just created, and edit the configuration for the new duplicated one.

Actual results:

It turns out both triggering conditions and actions are correctly copied, but the fields on when it's applied would be left on default values.

Expected results:

All settings of an existing filter shall be correctly copied.

Comment 1

[:aceman]

Yes, it seems the events triggering the filter are omitted from the copy when this was implemented in bug 214548.

Comment 2

[:aceman]

Attachment: 1523048.patch

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9040998 [details] [diff] [review]
1523048.patch

Thanks. The net change is a one liner here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70d44ca12af8
when copying a filter, copy its triggering events too (filterType). r=jorgk

Comment 5

[Jorg K (CEST = GMT+2)]

TB 66 beta:
https://hg.mozilla.org/releases/comm-beta/rev/fac9afbc5ce3

Comment 6

[Jorg K (CEST = GMT+2)]

TB 60.5.1:
https://hg.mozilla.org/releases/comm-esr60/rev/151ca8056889b1e9e84733fad43622e4e112b95e