Closed Bug 1523594 Opened 5 years ago Closed 5 years ago

Perma ccov JavascriptException: [Exception... "Component is not available" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py :: <TOP_LEVEL>

Categories

(Testing :: Code Coverage, defect, P5)

Version 3
defect

Tracking

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: kmag)

References

Details

(Keywords: regression, Whiteboard: [stockwell disable-recommended][wptsync upstream])

#[markdown(off)]
Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=224706737&repo=mozilla-central

https://queue.taskcluster.net/v1/task/OcnVbuo2Q3CcLGBGuBwvgw/runs/0/artifacts/public/logs/live_backing.log

Bug 1519596 and bug https://bugzilla.mozilla.org/show_bug.cgi?id=1514594 updated how ChromeUtils.import has to be done.

Update of executormarionette.py to new ChromeUtils.import (was not part of those 2 bugs): https://hg.mozilla.org/mozilla-central/rev/060d26e4a44201f51a7aae454d692d96103245f5

[task 2019-01-29T13:16:16.352Z] 13:16:16 INFO - Application command: /builds/worker/workspace/build/application/firefox/firefox --marionette about:blank -profile /tmp/tmptM5uuV.mozrunner
[task 2019-01-29T13:16:16.368Z] 13:16:16 INFO - Starting runner
[task 2019-01-29T13:16:16.472Z] 13:16:16 INFO - PID 915 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmptM5uuV.mozrunner/runtests_leaks_856.log
[task 2019-01-29T13:16:16.472Z] 13:16:16 INFO - PID 915 | [CodeCoverage] Setting handlers for process 915.
[task 2019-01-29T13:16:19.729Z] 13:16:19 INFO - PID 915 | 1548767779725 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
[task 2019-01-29T13:16:19.731Z] 13:16:19 INFO - PID 915 | 1548767779728 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
[task 2019-01-29T13:16:19.732Z] 13:16:19 INFO - PID 915 | 1548767779729 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: about:reader*
[task 2019-01-29T13:16:20.614Z] 13:16:20 INFO - PID 915 | [915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 318
[task 2019-01-29T13:16:20.618Z] 13:16:20 INFO - PID 915 | [915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 318
[task 2019-01-29T13:16:20.626Z] 13:16:20 INFO - PID 915 | [915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 318
[task 2019-01-29T13:16:20.627Z] 13:16:20 INFO - PID 915 | [915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 318
[task 2019-01-29T13:16:20.744Z] 13:16:20 INFO - PID 915 | [915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/extensions/cookie/nsPermissionManager.cpp, line 2946
[task 2019-01-29T13:16:20.954Z] 13:16:20 INFO - PID 915 | ++DOCSHELL 0x7f09368bb000 == 1 [pid = 915] [id = {2d9c4124-7e83-46f1-bc6d-882e81e6b4c4}]
[task 2019-01-29T13:16:20.954Z] 13:16:20 INFO - PID 915 | ++DOMWINDOW == 1 (0x7f0938a43800) [pid = 915] [serial = 1] [outer = (nil)]
[task 2019-01-29T13:16:20.956Z] 13:16:20 INFO - PID 915 | ++DOMWINDOW == 2 (0x7f0938a44000) [pid = 915] [serial = 2] [outer = 0x7f0938a43800]
[task 2019-01-29T13:16:21.077Z] 13:16:21 INFO - PID 915 | [915, Main Thread] WARNING: 'mIndex >= Count()', file /builds/worker/workspace/build/src/xpcom/ds/nsStringEnumerator.cpp, line 208
[task 2019-01-29T13:16:21.407Z] 13:16:21 INFO - PID 915 | ++DOCSHELL 0x7f0936968800 == 2 [pid = 915] [id = {b3299c09-adfe-493b-a6fc-9282da5b288c}]
[task 2019-01-29T13:16:21.408Z] 13:16:21 INFO - PID 915 | ++DOMWINDOW == 3 (0x7f0935b5b000) [pid = 915] [serial = 3] [outer = (nil)]
[task 2019-01-29T13:16:21.408Z] 13:16:21 INFO - PID 915 | ++DOMWINDOW == 4 (0x7f0935b5bc00) [pid = 915] [serial = 4] [outer = 0x7f0935b5b000]
[task 2019-01-29T13:16:21.537Z] 13:16:21 INFO - PID 915 | [915, Main Thread] WARNING: Attempting to get a displayport from a content with no primary frame!: file /builds/worker/workspace/build/src/layout/base/nsLayoutUtils.cpp, line 752
[task 2019-01-29T13:16:21.537Z] 13:16:21 INFO - PID 915 | ++DOMWINDOW == 5 (0x7f0935b67000) [pid = 915] [serial = 5] [outer = 0x7f0938a43800]
[task 2019-01-29T13:16:22.238Z] 13:16:22 INFO - PID 915 | ++DOCSHELL 0x7f0932741000 == 3 [pid = 915] [id = {408c41b1-fdf0-4065-b4c9-5c8345b1757e}]
[task 2019-01-29T13:16:22.238Z] 13:16:22 INFO - PID 915 | ++DOMWINDOW == 6 (0x7f0962b1d400) [pid = 915] [serial = 6] [outer = (nil)]
[task 2019-01-29T13:16:22.488Z] 13:16:22 INFO - PID 915 | ++DOCSHELL 0x7f0935cdf000 == 4 [pid = 915] [id = {e03079da-1bb3-42ac-8758-f1489f6e8960}]
[task 2019-01-29T13:16:22.488Z] 13:16:22 INFO - PID 915 | ++DOMWINDOW == 7 (0x7f0932928400) [pid = 915] [serial = 7] [outer = (nil)]
[task 2019-01-29T13:16:22.489Z] 13:16:22 INFO - PID 915 | ++DOMWINDOW == 8 (0x7f0932929c00) [pid = 915] [serial = 8] [outer = 0x7f0932928400]
[task 2019-01-29T13:16:22.706Z] 13:16:22 INFO - PID 915 | ++DOMWINDOW == 9 (0x7f0932177400) [pid = 915] [serial = 9] [outer = 0x7f0932928400]
[task 2019-01-29T13:16:23.267Z] 13:16:23 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Need TabChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1078
[task 2019-01-29T13:16:23.309Z] 13:16:23 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Need TabChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1078
[task 2019-01-29T13:16:23.326Z] 13:16:23 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Need TabChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1078
[task 2019-01-29T13:16:23.345Z] 13:16:23 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Need TabChild to get the nativeWindow from!: file /builds/worker/workspace/build/src/widget/PuppetWidget.cpp, line 1078
[task 2019-01-29T13:16:23.361Z] 13:16:23 INFO - PID 915 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmptM5uuV.mozrunner/runtests_leaks_856_tab_pid989.log
[task 2019-01-29T13:16:23.627Z] 13:16:23 INFO - PID 915 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-01-29T13:16:23.629Z] 13:16:23 INFO - PID 915 | [CodeCoverage] Setting handlers for process 989.
[task 2019-01-29T13:16:23.792Z] 13:16:23 INFO - PID 915 | ++DOCSHELL 0x7f7f394c8800 == 1 [pid = 989] [id = {65ec2ce5-96e2-455d-855b-b7d415b651ec}]
[task 2019-01-29T13:16:23.849Z] 13:16:23 INFO - PID 915 | ++DOMWINDOW == 1 (0x7f7f3940a400) [pid = 989] [serial = 1] [outer = (nil)]
[task 2019-01-29T13:16:23.850Z] 13:16:23 INFO - PID 915 | [Child 989, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/TabChild.cpp, line 2586
[task 2019-01-29T13:16:23.887Z] 13:16:23 INFO - PID 915 | ++DOCSHELL 0x7f7f39a1d000 == 2 [pid = 989] [id = {de7ffcf1-f11a-4dc8-98ed-eddc18c13807}]
[task 2019-01-29T13:16:23.888Z] 13:16:23 INFO - PID 915 | ++DOMWINDOW == 2 (0x7f7f39411c00) [pid = 989] [serial = 2] [outer = (nil)]
[task 2019-01-29T13:16:23.888Z] 13:16:23 INFO - PID 915 | [Child 989, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/TabChild.cpp, line 2586
[task 2019-01-29T13:16:23.896Z] 13:16:23 INFO - PID 915 | ++DOCSHELL 0x7f7f39a1f000 == 3 [pid = 989] [id = {76565f83-bc4f-44f7-b580-bfcf268052d3}]
[task 2019-01-29T13:16:23.896Z] 13:16:23 INFO - PID 915 | ++DOMWINDOW == 3 (0x7f7f3946c000) [pid = 989] [serial = 3] [outer = (nil)]
[task 2019-01-29T13:16:23.897Z] 13:16:23 INFO - PID 915 | [Child 989, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/TabChild.cpp, line 2586
[task 2019-01-29T13:16:23.904Z] 13:16:23 INFO - PID 915 | ++DOCSHELL 0x7f7f39a21800 == 4 [pid = 989] [id = {76f495ae-e8d2-4929-b19f-2d5d4367a64a}]
[task 2019-01-29T13:16:23.905Z] 13:16:23 INFO - PID 915 | ++DOMWINDOW == 4 (0x7f7f3946d000) [pid = 989] [serial = 4] [outer = (nil)]
[task 2019-01-29T13:16:23.905Z] 13:16:23 INFO - PID 915 | [Child 989, Main Thread] WARNING: Fallback to BasicLayerManager: file /builds/worker/workspace/build/src/dom/ipc/TabChild.cpp, line 2586
[task 2019-01-29T13:16:24.029Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 5 (0x7f7f3946e800) [pid = 989] [serial = 5] [outer = 0x7f7f3940a400]
[task 2019-01-29T13:16:24.090Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 6 (0x7f7f3a436000) [pid = 989] [serial = 6] [outer = 0x7f7f39411c00]
[task 2019-01-29T13:16:24.119Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 7 (0x7f7f3a436c00) [pid = 989] [serial = 7] [outer = 0x7f7f3946c000]
[task 2019-01-29T13:16:24.156Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 8 (0x7f7f3a437400) [pid = 989] [serial = 8] [outer = 0x7f7f3946d000]
[task 2019-01-29T13:16:24.177Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 9 (0x7f7f3a438800) [pid = 989] [serial = 9] [outer = 0x7f7f3940a400]
[task 2019-01-29T13:16:24.198Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 10 (0x7f7f3a43a000) [pid = 989] [serial = 10] [outer = 0x7f7f39411c00]
[task 2019-01-29T13:16:24.219Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 11 (0x7f7f3a43b400) [pid = 989] [serial = 11] [outer = 0x7f7f3946c000]
[task 2019-01-29T13:16:24.239Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 12 (0x7f7f3a43d000) [pid = 989] [serial = 12] [outer = 0x7f7f3946d000]
[task 2019-01-29T13:16:24.682Z] 13:16:24 INFO - PID 915 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmptM5uuV.mozrunner/runtests_leaks_856_tab_pid1016.log
[task 2019-01-29T13:16:24.791Z] 13:16:24 INFO - PID 915 | ++DOMWINDOW == 10 (0x7f0930a28400) [pid = 915] [serial = 10] [outer = 0x7f0962b1d400]
[task 2019-01-29T13:16:25.014Z] 13:16:25 INFO - PID 915 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-01-29T13:16:25.014Z] 13:16:25 INFO - PID 915 | [CodeCoverage] Setting handlers for process 1016.
[task 2019-01-29T13:16:25.212Z] 13:16:25 INFO - PID 915 | ++DOCSHELL 0x7f86818c3800 == 1 [pid = 1016] [id = {a8baf648-3d47-4c73-98cd-4377b318388f}]
[task 2019-01-29T13:16:25.268Z] 13:16:25 INFO - PID 915 | ++DOMWINDOW == 1 (0x7f8681861c00) [pid = 1016] [serial = 1] [outer = (nil)]
[task 2019-01-29T13:16:25.325Z] 13:16:25 INFO - PID 915 | ++DOMWINDOW == 2 (0x7f868187c000) [pid = 1016] [serial = 2] [outer = 0x7f8681861c00]
[task 2019-01-29T13:16:26.411Z] 13:16:26 INFO - PID 915 | ++DOMWINDOW == 3 (0x7f8681e93000) [pid = 1016] [serial = 3] [outer = 0x7f8681861c00]
[task 2019-01-29T13:16:26.831Z] 13:16:26 INFO - PID 915 | [Parent 915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/netwerk/cache/nsCacheService.cpp, line 192
[task 2019-01-29T13:16:27.175Z] 13:16:27 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/workspace/build/src/parser/html/nsHtml5StreamParser.cpp, line 1012
[task 2019-01-29T13:16:28.868Z] 13:16:28 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x7f0930eac550 (http://mzl.la/1FuID0j).: file /builds/worker/workspace/build/src/storage/mozStoragePrivateHelpers.cpp, line 108
[task 2019-01-29T13:16:29.893Z] 13:16:29 INFO - PID 915 | 1548767789882 Marionette INFO Listening on port 2828
[task 2019-01-29T13:16:30.241Z] 13:16:30 INFO - PID 915 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmptM5uuV.mozrunner/runtests_leaks_856_tab_pid1064.log
[task 2019-01-29T13:16:30.539Z] 13:16:30 INFO - PID 915 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-01-29T13:16:30.542Z] 13:16:30 INFO - PID 915 | [CodeCoverage] Setting handlers for process 1064.
[task 2019-01-29T13:16:30.603Z] 13:16:30 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 226
[task 2019-01-29T13:16:30.604Z] 13:16:30 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 226
[task 2019-01-29T13:16:30.604Z] 13:16:30 INFO - PID 915 | [Parent 915, Main Thread] WARNING: Found a principal with no URI, assuming third-party request: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 226
[task 2019-01-29T13:16:30.898Z] 13:16:30 INFO - PID 915 | [Parent 915, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file /builds/worker/workspace/build/src/startupcache/StartupCacheUtils.cpp, line 156
[task 2019-01-29T13:16:30.906Z] 13:16:30 ERROR - Traceback (most recent call last):
[task 2019-01-29T13:16:30.906Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/protocol.py", line 53, in setup
[task 2019-01-29T13:16:30.907Z] 13:16:30 ERROR - getattr(self, cls.name).setup()
[task 2019-01-29T13:16:30.907Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 424, in setup
[task 2019-01-29T13:16:30.907Z] 13:16:30 ERROR - self.is_enabled = self.marionette.execute_script(script)
[task 2019-01-29T13:16:30.908Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1761, in execute_script
[task 2019-01-29T13:16:30.908Z] 13:16:30 ERROR - rv = self._send_message("WebDriver:ExecuteScript", body, key="value")
[task 2019-01-29T13:16:30.909Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 26, in _
[task 2019-01-29T13:16:30.909Z] 13:16:30 ERROR - return func(*args, **kwargs)
[task 2019-01-29T13:16:30.910Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 764, in _send_message
[task 2019-01-29T13:16:30.910Z] 13:16:30 ERROR - self._handle_error(err)
[task 2019-01-29T13:16:30.911Z] 13:16:30 ERROR - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 784, in _handle_error
[task 2019-01-29T13:16:30.911Z] 13:16:30 ERROR - raise errors.lookup(error)(message, stacktrace=stacktrace)
[task 2019-01-29T13:16:30.912Z] 13:16:30 ERROR - JavascriptException: [Exception... "Component is not available" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py :: <TOP_LEVEL> :: line 425" data: no]
[task 2019-01-29T13:16:30.913Z] 13:16:30 ERROR - stacktrace:
[task 2019-01-29T13:16:30.913Z] 13:16:30 ERROR - @tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py:425:38
[task 2019-01-29T13:16:30.914Z] 13:16:30 ERROR - @tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py:424:2
[task 2019-01-29T13:16:30.915Z] 13:16:30 ERROR - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:129:13
[task 2019-01-29T13:16:30.916Z] 13:16:30 ERROR - evaluate.sandbox@chrome://marionette/content/evaluate.js:96:17
[task 2019-01-29T13:16:30.916Z] 13:16:30 ERROR - GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1021:19
[task 2019-01-29T13:16:30.917Z] 13:16:30 ERROR - async*GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:902:24
[task 2019-01-29T13:16:30.919Z] 13:16:30 ERROR - Async*despatch@chrome://marionette/content/server.js:290:20
[task 2019-01-29T13:16:30.919Z] 13:16:30 ERROR - async*execute@chrome://marionette/content/server.js:263:11
[task 2019-01-29T13:16:30.920Z] 13:16:30 ERROR - async*onPacket/<@chrome://marionette/content/server.js:236:15
[task 2019-01-29T13:16:30.921Z] 13:16:30 ERROR - async*onPacket@chrome://marionette/content/server.js:235:8
[task 2019-01-29T13:16:30.921Z] 13:16:30 ERROR - _onJSONObjectReady/<@chrome://marionette/content/transport.js:492:9
[task 2019-01-29T13:16:30.922Z] 13:16:30 ERROR -
[task 2019-01-29T13:16:30.923Z] 13:16:30 ERROR -
[task 2019-01-29T13:16:30.984Z] 13:16:30 INFO - Browser exited with return code -15

Regression from bug 1514594.

Blocks: 1514594
Flags: needinfo?(mcastelluccio) → needinfo?(kmaglione+bmo)

This failure doesn't make sense to me. The code was updated to match the new model, and I can't see how we'd get NS_ERROR_NOT_AVAILABLE on this line...

Flags: needinfo?(kmaglione+bmo)

Should we try to backout and see if it fixes the problem? Or are you going to fix this?

(Code coverage is tier-2, so while a breakage doesn't cause automatic backout, the problem should be fixed or the regressing change should be backed out)

Flags: needinfo?(kmaglione+bmo)

Henrik, can you take a look why we get an exception here? Code was updated with https://hg.mozilla.org/mozilla-central/rev/060d26e4a44201f51a7aae454d692d96103245f5

Flags: needinfo?(hskupin)

The JS traceback shows that there is a call to execute_script (evaluate.sandbox) in Marionette, which means that the wptrunner code is passing over a script. Which in this case is the following:

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py#427-432

Here the coverage utils are getting imported the following way:

ChromeUtils.import("chrome://marionette/content/PerTestCoverageUtils.jsm");

Given bug 1514594 comment 13 this should be:

let {PerTestCoverageUtils} = ChromeUtils.import("chrome://marionette/content/PerTestCoverageUtils.jsm");

I assume the script Kris ran only touched JS source files, and as such missed scripts like those as defined in Python code?

Marco, I think it's your part to get this fixed.

Flags: needinfo?(hskupin) → needinfo?(mcastelluccio)

That change has already been made (see comment 4) and switching from |const| to |let| doesn't change the behavior. Any other idea?

Flags: needinfo?(hskupin)

Then please provide a new failure message and trace.

Flags: needinfo?(hskupin) → needinfo?(aryx.bugmail)

It's the one in comment 0.

Flags: needinfo?(aryx.bugmail)

No, because wptrunner is not really the component I'm doing much work in. Best would be to ask maybe James Graham.

Flags: needinfo?(james)

It looks reasonable with the changes, so I'm not sure what's broken at first glance. Maybe Marco's first glance is better than mine? Otherwise redirect back to me and I'll take a deeper look (note that searchfox seems to have the old code).

(seems I failed to actually ni? marco)

Flags: needinfo?(james)

I honestly have no idea, because I don't know exactly what bug 1514594 changed.

This is how we are importing PerTestCoverageUtils.jsm:
https://hg.mozilla.org/mozilla-central/file/0a71d114c5e2/testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py#l420

This is PerTestCoverageUtils.jsm:
https://hg.mozilla.org/mozilla-central/file/0a71d114c5e2/tools/code-coverage/PerTestCoverageUtils.jsm

Kris, do you see anything we need to change after the changes from bug 1514594?

Flags: needinfo?(mcastelluccio)

Is there a mach command locally which could be used to retrigger the problem? I only see coverage for Windows and Linux, would it also work on MacOS?

You'd need to use a coverage build, you can make one on Mac with this mozconfig https://searchfox.org/mozilla-central/source/browser/config/mozconfigs/macosx64/code-coverage.

Sorry but due to traveling I cannot help right now. But you could try to modify the script eg. by trying to load a different module. If that succeeds you know that something might be broken inside of PerTestCoverageUtils.jsm.

Ah, I see now. Someone botched the update of this script. It changed the import of "chrome://marionette/content/PerTestCoverageUtils.jsm" to "resource://reftest/PerTestCoverageUtils.jsm", which only works when the reftest extension is loaded (which, for these tests, it is not)

Flags: needinfo?(kmaglione+bmo)

(In reply to Kris Maglione [:kmag] from comment #19)

Ah, I see now. Someone botched the update of this script. It changed the import of "chrome://marionette/content/PerTestCoverageUtils.jsm" to "resource://reftest/PerTestCoverageUtils.jsm", which only works when the reftest extension is loaded (which, for these tests, it is not)

That was https://hg.mozilla.org/integration/mozilla-inbound/rev/060d26e4a442 from bug 1519596.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → kmaglione+bmo

Thanks, it was hard to spot!

No longer blocks: 1514594
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15230 for changes under testing/web-platform/tests
Whiteboard: [stockwell disable-recommended] → [stockwell disable-recommended][wptsync upstream]
You need to log in before you can comment on or make changes to this bug.