1523696 - Clear Recent History dialog is too small, hiding options

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[u632445]

Attachment: clear_history_dialog_issue.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Icon "Show your history" -> option "Clear Recent History...":

Opened modal dialog "Clear All History" is incorrectly resized hiding an area below section "Data" including buttons "Clear Now" and "Cancel", see attached file "clear_history_dialog_issue.png", another attachment "clear_history_dialog.png" is a dialog of the correct size.

Actual results:

That issue happened randomly usually on the first click, second click opens a dialog of the correct size.

Tested on Firefox Developer Edition 66.0b2.

Comment 1

[Gingerbread Man]

Triaging to General because of bug 1351428, comment 2. I would've thought this belongs in Toolkit :: Data Sanitization but apparently not.

Comment 4

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
20190124174741

I managed to reproduce this once after I don't know how many attempts. I tried another 15 times but the dialog was a normal size.

Comment 6

[Gingerbread Man]

:adw this has collected some duplicates. Since you fixed bug 495452, maybe you'd be interested in taking a look, or know someone who is.

Comment 7

[Walter Labonte]

A similar bug was happened a few days ago.
https://bugzilla.mozilla.org/show_bug.cgi?id=1518786

Comment 8

[Drew Willcoxon :adw]

I'm not able to look at this right now, and I'm not sure who worked on this last. It may have been a while since anyone has. I'll add myself to the bug as the mentor though in case a contributor is interested in fixing it.

Comment 9

[Matthew N. [:MattN]]

Like bug 1518786, this seems like a regression from bug 1498444 though I didn't confirm.

Comment 10

[:Gijs (he/him)]

This dialog isn't part of preferences, see screenshot in the zipfile which shows a native win7 dialog.

It can also be opened from preferences, and we fixed that version in bug 1514652.

I guess we need to call sizeToContent() in the non-preferences case. Jared, does that seem right?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, I'll take this.

Comment 12

[Matthew N. [:MattN]]

(In reply to :Gijs (he/him) from comment #10)

This dialog isn't part of preferences, see screenshot in the zipfile which shows a native win7 dialog.

I know… I was following the component of bug 1498444 which regressed this though.

It can also be opened from preferences, and we fixed that version in bug 1514652.

I guess we need to call sizeToContent() in the non-preferences case. Jared, does that seem right?

Comment 13

[Gingerbread Man]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #12)

I was following the component of bug 1498444 which regressed this

So now this is in Bookmarks & History though Marco Bonardo said it doesn't belong here, as I initially mentioned in comment 1.

Comment 14

[Marco Bonardo [:mak]]

¯_(ツ)_/¯ => Back to general (the Clear Recent History dialog doesn't actually have a home)

Comment 15

[Johann Hofmann [:johannh]]

If we're okay with a toolkit component despite this being a browser thing I'll adopt it into Data Sanitization.

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: clear_history_dialog.png

Comment 18

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: clear_history_dialog_issue.png

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1523696 - Wait until the style attribute is applied to the dialog before sizing it. r?Gijs

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1feee32f9793
Wait until the style attribute is applied to the dialog before sizing it. r=Gijs

Comment 21

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1feee32f9793

Comment 22

[Walter Labonte]

Attachment: dialog.png

Still problem a little.
Lack of right side of the dialog.
Nightly 67.0a1 (2019-02-08)
build id: 20190208095514
Language: ja

Comment 23

[:Gijs (he/him)]

(In reply to Walter Labonte from comment #22)

Created attachment 9042528 [details]
dialog.png

Still problem a little.
Lack of right side of the dialog.
Nightly 67.0a1 (2019-02-08)
build id: 20190208095514
Language: ja

This is inside the preferences again... was this a problem on the previous nightly as well?

Either way, this probably wants to be a new bug - could you file one please?

Comment 24

[Walter Labonte]

I posted it as a new bug report.
https://bugzilla.mozilla.org/show_bug.cgi?id=1526379

And i don't know that it was happened on the previous nightly.

Comment 25

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9042239 [details]
Bug 1523696 - Wait until the style attribute is applied to the dialog before sizing it. r?Gijs

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1498444

User impact if declined

The Clear Recent History dialog may be sized too small for users to actually click the button to clear their history.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

No

Needs manual test from QE?

Yes

If yes, steps to reproduce

(requesting QE verification since this just landed on m-c and uplift request is for release)
0. Make sure you are using a temporary profile or one you are OK with losing history

1. Go to about:config and set layout.css.devPixelsPerPx to 2.5 or 1.25 if 2.5 is too big
2. Open the Clear Recent History dialog by pressing Ctrl+Shift+Del on Windows, Cmd+Shift+Del on MacOS
3. Change the selected timespan to Everything
4. Press the "Clear Now" button
5. Reopen the dialog, look for any parts being cut off otherwise choose "Last Hour"
6. Press the "Clear Now" button
   (repeat steps 3-6 multiple times if not reproduced on the first step)

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Waits for localization to complete then uses the sizeToContent method to make sure the dialog is large enough for its content. The change is localized and only affects the Clear Recent History dialog.

String changes made/needed

none

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9042239 [details]
Bug 1523696 - Wait until the style attribute is applied to the dialog before sizing it. r?Gijs

[Triage Comment]
Avoid improperly-sized dialog boxes in some situations. Approved for 66.0b7 and 65.0.1.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0b5b2b73fb13

Comment 28

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b61d0fdc785b

Comment 29

[pezbot50]

I'm seeing same bug. Happens every time I start new Firefox Mozilla Session. Rev 65.0 (64 bit). Windows 7.0. History settings: Everything, every box checked. (This bug began after updating to Rev 65.0 several days ago.) Also, now happens on second PC running Windows 7.0 when it was updated. Thx.

Comment 30

[Camelia Badau [:cbadau], Desktop QA]

I've tested on Windows 7 x64, Windows 7 x86, Windows 10 x64 using Firefox 65.0, Firefox Developer Edition 66.0b2. I tried multiple times (~50 times), but I wasn't able even once to reproduce the issue, therefore I can't consider the verification reliable from my side.

Could you please help us to confirm this fix on Firefox 66 Beta 6 and latest Nightly 67.0a1?

Comment 32

[u632445]

(In reply to Camelia Badau [:cbadau], Release Desktop QA from comment #30)

I've tested on Windows 7 x64, Windows 7 x86, Windows 10 x64 using Firefox 65.0, Firefox Developer Edition 66.0b2. I tried multiple times (~50 times), but I wasn't able even once to reproduce the issue, therefore I can't consider the verification reliable from my side.

Could you please help us to confirm this fix on Firefox 66 Beta 6 and latest Nightly 67.0a1?

The issue is obsolete and resolved.

Comment 33

[:Gijs (he/him)]

Marking verified per comment #32.

Comment 34

[Martt Harding]

Bug 1523696 - Clear Recent History dialog is too small, hiding options

The above is listed as fixed and closed. Which I assume it was, three years ago when the original bug was worked.

However as of Thunderbird ver 91.4.0 (64-bit) running on a Windows 10 PC, it is no longer fixed. Same problem I suspect, the dialog box is too small and not resizable, thus the options cannot be read. And if inferred and selected, the "Clear Now" button is no longer accessible; it disappears off the bottom of the dialog box.

Perhaps not relevant, but Thunderbird ver 91.2.1 (32-bit) running on a Windows 7 PC displays a usable version of the Clear Recent History dialog box. That I how I was able to see what ver 91.4.0 should have displayed.

Martt Harding
[e-mail]

Comment 35

[:Gijs (he/him)]

(In reply to Martt Harding from comment #34)

Bug 1523696 - Clear Recent History dialog is too small, hiding options

The above is listed as fixed and closed. Which I assume it was, three years ago when the original bug was worked.

However as of Thunderbird ver 91.4.0 (64-bit) running on a Windows 10 PC, it is no longer fixed.

Please file a separate bug against Thunderbird.