No longer able to send stereo audio when setting fmtp stereo=1 in the sdp
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | wontfix |
firefox66 | + | verified |
firefox67 | --- | verified |
People
(Reporter: adam, Assigned: drno)
References
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
As of Firefox 65 stereo audio has stopped working for us with TokBox/OpenTok.
Steps to reproduce:
- Open https://opentok.github.io/opentok-web-samples/Stereo-Audio/ in 2 tabs
- Click the Publish button when it appears in one of the tabs
- You should now hear a funky guitar riff 🎸🎵
- Use the slider to adjust the pan value left and right
Expected Result: You should hear the audio move from the left side to the right side of your speakers. This works in Firefox 64 and below.
Actual Result: The audio does not pan left and right.
To do this we are modifying the SDP offer like so:
a=fmtp:109 maxplaybackrate=48000;useinbandfec=1; sprop-stereo=1
and the answer like so:
a=fmtp:109 useinbandfec=1; stereo=1
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by nohlmeier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f854b755c2d set Opus stereo on send stream with 2 channels. r=dminor
Assignee | ||
Comment 5•5 years ago
|
||
[Tracking Requested - why for this release]: This is a bad regression as stereo audio over WebRTC is no longer working any more. We don't know how often stereo audio is used in the field. But we should try to get this fixed as soon as possible (assuming it's too late for 65).
Comment 6•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
I can confirm that the audio move from the left side to the right side of the speakers once I use the slider to adjust the pan value left and right on Firefox Nightly 67.0a1 (2019-02-04) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.14 and on Ubuntu 16.04 x64.
But the sound only works after I clicked on "Publish" on both tabs not just on one of them like what was mentioned above, and the sound was controlled from the second tab I published but was heard from the first tab, so am not sure about the steps above and what is the correct behavior in this case.
I compared what happening on chrome also and there I only had to click publish on one tab, and unmute the other one, and the sound was controlled form the tab which was published.
Could you please confirm if these are the expected behavior or not?
Thanks.
Assignee | ||
Comment 9•5 years ago
|
||
I keep seeing "Error: MediaDecodeAudioDataInvalidContent" now if I click in Nightly 2019-02-04. But I think that looks like some kind of race condition in the test pages JS code to me.
How many times you have to click on the demo page is not important for the verification of this. Important is that once you are connected and see the slider for panning you can hear the audio panning between both sides (which is not the case in 66). So it sounds to me like you were able to successfully verify the fix is working.
Comment 10•5 years ago
|
||
Verified as fixed on Firefox Nightly 67.0a1 (2019-02-04) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.14 and on Ubuntu 16.04 x64.
Assignee | ||
Comment 11•5 years ago
|
||
Comment on attachment 9040321 [details]
Bug 1524145: set Opus stereo on send stream with 2 channels. r?dminor
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
Stereo sound in WebRTC no longer works.
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
N/A
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
The patch only turns on certain features like stereo sound (and others) when using the Opus sound in WebRTC audio connections. This only happens when explicitly requested by the app (stereo is off by default), so it doesn't affect all WebRTC services.
Plus the code change is now covered with lots of additional testing.
String changes made/needed
N/A
Comment 12•5 years ago
|
||
Comment on attachment 9040321 [details]
Bug 1524145: set Opus stereo on send stream with 2 channels. r?dminor
Fix for recent regression, verified in nightly.
Code coverage looks good. Thanks for adding new tests!
Updated•5 years ago
|
Comment 13•5 years ago
|
||
bugherder uplift |
Comment 14•5 years ago
|
||
Verified as fixed on Firefox 66.0b8 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.14 and on Ubuntu 16.04 x64.
Updated•5 years ago
|
Description
•