1524158 - markdown generated by approval comment form could be improved

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

the comments generated by the approval comment generator are a bit hard on the eyes

-=-=-=-=-

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

personalized recommendations would appear in private browsing

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

covered by test, but manual str if desired would be to check for the header via network monitor on a private window.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

minimal change

String changes made/needed

none

-=-=-=-=-

playing around it looks a bit more readable with the next step down of headers

-=-=-=-=-

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

personalized recommendations would appear in private browsing

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

No

Needs manual test from QE?

No

If yes, steps to reproduce

covered by test, but manual str if desired would be to check for the header via network monitor on a private window.

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

minimal change

String changes made/needed

none

-=-=-=-=-

Comment 1

[Kohei Yoshino [:kohei]]

Agreed. Making the change now.

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 3

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 4

[Kohei Yoshino [:kohei]]

It could be further improved by using a table.

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request v2

Comment 6

[Kohei Yoshino [:kohei]]

Actually I didn’t use a table, because it cannot contain line breaks. On GitHub <br> works but on Bugzilla HTML tags will be escaped…

Comment 7

[Kohei Yoshino [:kohei]]

v2 merged to master.

Comment 8

[Kohei Yoshino [:kohei]]

I just was Bug 1522923 Comment 5 and this is much better!