1524213 - phabricator revisions list on bug page has extra / in the revision link

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Clicking on "Subscribe"/"Unsubscribe" on Phabricator/Differential pages redirects to https://D<differential id>/

E.g. click on "Subscribe"/"Unsubscribe" at https://phabricator.services.mozilla.com//D18082

A reload of the page shows the subscription status has changed.

Fallout from the upgrade in bug 1523612?

Comment 1

[David Lawrence [:dkl]]

Ok so if you include the extra slash in the revision URL, the subscribe/unsubscribe button fails. If the extra slash is missing then it works as expected.

Fails:
https://phabricator.services.mozilla.com//D18082

Works:
https://phabricator.services.mozilla.com/D18082

I can file this with the upstream and see if they can suggest a fix.

Where did you get the failing URL? From an email from Phabricator? Somewhere external?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Go to bug 1524213 and click the ID on the left of the phabricator revisions list.

Comment 3

[David Lawrence [:dkl]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)

Go to bug 1524213 and click the ID on the left of the phabricator revisions list.

Ah I see that. That is a BMO extension we wrote so that is our fault. I will get that fixed. Thanks.

Comment 4

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 5

[David Lawrence [:dkl]]

Merged to master.