Flip `dom.push.alwaysConnect` to true
Categories
(Core :: DOM: Push Subscriptions, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
This has now been rolled out via Shield to everyone on release, so let's flip the pref (https://searchfox.org/mozilla-central/rev/e62b311b2e0e02633afda2004ba4056b09fbcaa4/modules/libpref/init/all.js#5216) to true and uplift to Beta.
Comment 1•5 years ago
|
||
The priority flag is not set for this bug and there is no activity for 2 weeks.
:overholt, could you have a look please?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Phil and JR, would you mind creating accounts on Phabricator so I can send you reviews for Desktop patches? 😉 Thanks!
Assignee | ||
Comment 3•5 years ago
|
||
Also, remove a test that's no longer relevant, since we don't need to
fetch all subscriptions at startup.
Updated•5 years ago
|
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88ea72c345ab Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey
Comment 7•5 years ago
|
||
Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233817923&repo=autoland&lineNumber=33606
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-e10s-2&revision=88ea72c345aba0ede0433cc0db9e86bff5525bc1
Backout:
Backed out changeset 88ea72c345ab (bug 1524655) for mochitest failures in dom/push/test/test_error_reporting.html
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab709310d23f Backed out changeset 88ea72c345ab for mochitest failures in dom/push/test/test_error_reporting.html
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f32dc8409c3d Remove `dom.push.alwaysConnect` and connect unconditionally. r=jrconlin,pjenvey
Comment 11•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 12•5 years ago
|
||
After discussion with :lina, it sounds like we don't need a release note or MDN docs on this, so removing DDN.
Description
•