1525193 - [about:addons] Move add-on's list actions into a more options menu

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

The Disable and Remove buttons should be behind a more options popup [1] instead of being always visible buttons.

[1] https://mozilla.invisionapp.com/share/W2DW6NYX9#/screens/256825113

Comment 1

[BelFox]

As a long-time Firefox user, I'd prefer to keep the 3 separate buttons for

1. enable/disable extension (toggle)
2. remove extension
3. extension options

I often change the extension options from the Add-ons manager (this would now take 3 clicks instead of 1!) or quickly enable/disable several extensions for debugging purposes.

For fluent add-on management, efficiency is more important than esthetics. Why don't you provide three small buttons with an icon to save enough space for the add-on title and description? See also the closing words and comments on https://www.ghacks.net/2019/02/19/a-first-look-at-firefoxs-updated-add-ons-manager/. Other people share this need for efficiency.

Thank you for taking this into consideration.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525193 - Rename page-action.svg to more.svg, move to toolkit

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525193 - Move actions to more options menu in HTML about:addons

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525193 - HTML ghost button styles

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e1a91cd78fe
Rename page-action.svg to more.svg, move to toolkit r=dao
https://hg.mozilla.org/integration/autoland/rev/e08f9ad9fcbb
Move actions to more options menu in HTML about:addons r=Gijs,flod
https://hg.mozilla.org/integration/autoland/rev/77dbfa3a6e55
HTML ghost button styles r=dao

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2e1a91cd78fe
https://hg.mozilla.org/mozilla-central/rev/e08f9ad9fcbb
https://hg.mozilla.org/mozilla-central/rev/77dbfa3a6e55

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4855

Comment 8

[Mark Striemer [:mstriemer]]

The extension management options should now be in the more options menu (... button). The Disable/Enable and Remove buttons should work as expected. The More Options button is currently a placeholder until bug 1525173 lands.

Comment 9

[CosminB]

Attachment: Bug1525193.gif

This issue is verified as fixed on Firefox 68.0a1 (20190408193006) and Firefox 67.0b9 - build1 (20190408123043) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Comment 10

[Onno Ekker [:nONoNonO UTC+1]]

A little while ago I filed a but to make the option "Install Add-on From File…" and other add-on options more easily accessible, because at the moment it is only available from the popup menu under the Tools button in the old add-ons manager. This makes it hard to access the feature by keyboard only and possibly also for people with a screen reader (bug 1526232).

With this new implementation where the buttons per add-on are replaced by a single clickable element which hides the menuitems it seems like you do it the other way around and make the other add-on buttons harder to reach by keyboard. This will only be worse when it will be converted to HTML.

Please consider also adding real menus/menuitems to access add-on functions.