Closed Bug 1527005 Opened 5 years ago Closed 5 years ago

WebSocketChannel hangs waiting for OnTransportAvailable when server responds to upgrade request with HTTP/1.0

Categories

(Core :: Networking: WebSockets, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: michal, Assigned: michal)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

When server responds with "HTTP/1.0 101 Switching Protocols" to an upgrade request we process the response and wait for WebSocketChannel::OnTransportAvailable which is never called because the upgrade isn't performed for HTTP/1.0 at https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/netwerk/protocol/http/nsHttpChannel.cpp#7595.

Attached patch fixSplinter Review
Attachment #9043037 - Flags: review?(dd.mozilla)
Attachment #9043037 - Flags: review?(dd.mozilla) → review+
Priority: P1 → P2
Whiteboard: [necko-triaged]
Keywords: checkin-needed

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/609114233603
WebSocketChannel hangs waiting for OnTransportAvailable when server responds to upgrade request with HTTP/1.0, r=dragana

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: