Closed Bug 1528844 Opened 5 years ago Closed 5 years ago

[BinAST] Remove ParseNodeAllocator from BinASTParserBase

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

We should move all those allocation into handler.

BinASTParserBase::allocParseNode was used only for creating
ParseNodeKind::ParamsBody node, and other nodes are created by FullParseHandler.
Added FullParseHandler::newParamsBody and removed ParseNode allocation
methods from BinASTParserBase.

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/58e77ffe2a65
Move ParseNode allocation from BinASTParserBase to FullParseHandler. r=Yoric
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1530389
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: