1529285 - Rename Cookie::httpOnly to ::http_only

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The Cookie::httpOnly field should be renamed http_only (with
underscore).

This requires a special serde directive so it knows to deserialise
to and fro the JSON field name httpOnly.

Comment 1

[Shivam Singhal [ :championshuttler ]]

Hi Andreas, I would like to work on it , I build the firefox locally and laptop already.

Comment 2

[Andreas Tolfsen ❲:ato❳]

(In reply to Shivam Singhal [ :championshuttler ] from comment #1)

Hi Andreas, I would like to work on it , I build the firefox
locally and laptop already.

Try to see if you can upload the patch for this to Phabricator. It
requires a bit of perseverance, but the gist of getting the compile
environment set up is outlined in
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction,
and Phabricator (MozReview) is documented in
https://moz-conduit.readthedocs.io/en/latest/.

Comment 3

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1529285 - Rename Cookie::httpOnly to ::http_only. r=ato

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/070e1065af52
Rename Cookie::httpOnly to ::http_only. r=ato

Comment 5

[Andreas Tolfsen ❲:ato❳]

Thank you for the contribution!

Comment 6

[Shivam Singhal [ :championshuttler ]]

Yey! Thanks for the help Andrew. Have a great weekend!

Best
Shivam

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/070e1065af52

Comment 8

[Florin Strugariu [:Bebe]]

== Change summary for alert #19848 (as of Sun, 10 Mar 2019 15:43:18 GMT) ==

Improvements:

4% tp5o_scroll windows7-32 pgo e10s stylo 1.39 -> 1.34

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19848

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Florin Strugariu [:Bebe] from comment #8)

== Change summary for alert #19848 (as of Sun, 10 Mar 2019 15:43:18 GMT) ==

Improvements:

4% tp5o_scroll windows7-32 pgo e10s stylo 1.39 -> 1.34

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=19848

This change can't have made a perf improvement to Firefox at all because it's only geckodriver related, and only a variable name was changed.