Closed
Bug 1529442
Opened 5 years ago
Closed 5 years ago
[BinAST] Remove BinASTParserBase fields, or maybe the class itself
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
After bug 1528837, BinASTParserBase has only 2 fields, and they're not actually used by this class.
we can move it to BinASTParserPerTokenizer, or just remove BinASTParserBase.
(we still have GC related methods and virtual method there tho)
|
Assignee | |
Comment 1•5 years ago
|
||
Both BinASTParserBase.{lazyScript_,handler_} are not used in BinASTParserBase,
but in BinASTParserPerTokenizer.
Moved them to BinASTParserPerTokenizer.
Depends on D20774
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/b5889271779f Move BinASTParserBase fields to BinASTParserPerTokenizer. r=Yoric
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•