Closed Bug 153035 Opened 22 years ago Closed 22 years ago

use non-standard line-height for blocks that do not contain text nodes

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED WONTFIX

People

(Reporter: megabyte, Assigned: attinasi)

References

(
URL
)

Details

This is based on bug 151620 comment 52 and bug 151620 comment 53.

In order to cover bug 151620 comment 24, we could use "strict" line-heights on
inline items only if there were #text nodes present in the containing block. 
Otherwise we would use the quirks-type calculation.  This way if you had text,
you'd presumably want the line-height to match that and use strict rendering,
but if you did not have text, then you would not gain the seemingly magical (to
anybody not familiar with the issues) line-height and it would work like it has
in the past.  Also, if a line-height was explicitly applied, it would be honored
instead of following the above formula.  (So we don't get another bug like bug
152959).  It would only be the inherited line-height's that would go through
this "filter."  The benefits over bug 22274's resolution would be that most (if
not all) pages should work (and it would cover <div>s too), and the benefit over
bug 151620's resolution would be that we could still get the strict rendering in
<td> elements.  Work on this should completely replace the patches for bug
151620 and bug 152979 and bug 152959 (if one is made).  This is the logic that
should be used especially if bug 153032 is implemented.
Depends on: 153032
No longer depends on: 153032
Depends on: 153032
Why would those tests fail?  "Also, if a line-height was explicitly applied, it
would be honored instead of following the above formula."  Those tests have
line-height defined for the containing elements.
This suggestion would still cause the following testcases to fail:
   http://www.hixie.ch/tests/adhoc/css/box/inline/010.xml
   http://www.hixie.ch/tests/adhoc/css/box/inline/010.html

(And anyway, per CSS, you can't tell the difference between a property that is
present in an author stylesheet and one that is not -- all properties are always
set, even if merely by inheritance, or by the UA stylesheet, or whatever. That
really shouldn't change, not even in quirks mode.)
> In order to cover bug 151620 comment 24, we could use "strict" line-heights on
> inline items only if there were #text nodes present in the containing block. 
> Otherwise we would use the quirks-type calculation.

That's basically what the quirks mode algorithm is, and it's a major change.

> Also, if a line-height was explicitly applied, it would be honored
> instead of following the above formula.

This is hard to implement and makes no sense in the CSS model.

->WONTFIX
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WONTFIX
VERIFIED WONTFIX, the trimode model makes more sense
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.