1530936 - Add a `role="main"` attribute to the output element

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

Comment 1

[Erik Carrillo [:E_Carr]]

(In reply to Nicolas Chevobbe from comment #0)

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

Hello again Nicolas, could I please be assigned this bug? Thank you.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Sure Erik, just did :) Thanks for taking this bug!

Comment 3

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1530936 - Add a role=main attribute to the output element. r=nchevobbe

Added a role=main attribute to address accessability within the browser console.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1976157b0c74
Add a role=main attribute to the output element. r=nchevobbe

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1976157b0c74