1531419 - Font Editor: fix issues raised by React in dev mode

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Razvan Caliman [:rcaliman]]

There are historical issue in the Font Editor which stem from improper use of React and sloppy type coercion:

• missing key properties in lists of rendered components
• typos in element attributes as expected by React (ex: maxlength => maxLength)
• incorrect type for axis & font property values as defined by component propTypes.

The React errors do not impact end users, but make for a noisy console. The inconsistent types for values create potential for new bugs.

The patch for this bugs corrects many of these issues.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1531419 - Address errors shown by React in dev mode for Font Editor; r=gl

• add key where necessary;
• fix element attribute typos;
• use consistent Number type for axis and font property values as defined by propTypes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5936ae0c1d6
Address errors shown by React in dev mode for Font Editor; r=gl

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f5936ae0c1d6