Closed Bug 1531658 Opened 5 years ago Closed 5 years ago

Absolute paths to icons are broken

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Version:
67 Branch
Platform:
x86_64
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: alice0775, Assigned: aswan)

References

Details

(Keywords: nightly-community, regression, Whiteboard: [testday-20190329] )

Attachments

(2 files)

image.png
41.82 KB, image/png
Details
Bug 1531658 Fix up absolute icon paths r=kmag
47 bytes, text/x-phabricator-request
Details | Review
Attached image image.png —

Reproducible: always

Steps to reproduce:

  1. Install https://addons.mozilla.org/ja/firefox/addon/greasemonkey/
  2. Open addon manager

Actual Results:
"LEGACY" is displayed

Expected results:
It is not "LEGACY", shouls not add "LEGACY"

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=603a46a1e921a1fae58fa168461935a42270c1f0&tochange=6ad7a291385a560da0a7b7019f03f9afde786112

Suspect: Bug 1529374

Broser console shows an error:
Error: getResourceURI() must receive a relative path XPIDatabase.jsm:1034:15
getResourceURI resource://gre/modules/addons/XPIDatabase.jsm:1034
get icons resource://gre/modules/addons/XPIDatabase.jsm:758
getPreferredIconURL resource://gre/modules/AddonManager.jsm:2119
getPreferredIconURL resource://gre/modules/AddonManager.jsm:3486
_initWithAddon chrome://mozapps/content/extensions/extensions.xml:878
generic_XBL_Constructor chrome://mozapps/content/extensions/extensions.xml:699
show chrome://mozapps/content/extensions/extensions.js:2626
getAddonsAndInstalls chrome://mozapps/content/extensions/extensions.js:1822
InterpretGeneratorResume self-hosted:1255
next self-hosted:1210

Blocks: 1529374
Keywords: nightly-community
Has Regression Range: --- → yes
Has STR: --- → yes

The folowing addon is also affected.
https://addons.mozilla.org/en-US/firefox/addon/styl-us/

Hi, same here.
Here are some examples that become labeled as legacy.

https://addons.mozilla.org/ru/firefox/addon/foxclocks/
https://addons.mozilla.org/ru/firefox/addon/web-developer/

Also their icons changed to default one and it isn't possible to access their summary card.

Summary: "LEGACY" is displayed → "LEGACY" is displayed, icons changed to default one and it isn't possible to access their summary card and options

And [Disable]/[Enable], [Remove] does not update button status after fails detail/options.

:aswan,
Can you please look into this?

Flags: needinfo?(aswan)

Thanks for all the reports, I understand the underlying issue, we don't need to keep enumerating affected extensions.

Assignee: nobody → aswan
Flags: needinfo?(aswan)
Priority: -- → P1
Summary: "LEGACY" is displayed, icons changed to default one and it isn't possible to access their summary card and options → Absolute paths to icons are broken
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4a6fcff18b3
Fix up absolute icon paths r=kmag

https://hg.mozilla.org/mozilla-central/rev/e4a6fcff18b3

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
QA Whiteboard: [good first verify]

I have reproduced this bug with Nightly 67.0a1 (2019-02-28) on Windows 7, 64 Bit.
This bug's fix is verified with latest Beta 67.0b6!

Build ID : 20190328152334
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Whiteboard: [testday-20190329]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: