Closed Bug 1532421 Opened 5 years ago Closed 5 years ago

Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub

Categories

(Core :: JavaScript Engine: JIT, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(1 file)

I feel like in this specific case ValueType doesn't improve the situation very much, because the bit flag system already makes everything kind of annoying. Especially for ValidFlags I would like some ideas on how to do that exhaustively. (i.e. note the gap between JSVAL_TYPE_BIGINT and JSVAL_TYPE_OBJECT that we don't even detect)

Priority: -- → P1
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cce35becf719
Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub. r=mgaudet
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: