Closed
Bug 1532421
Opened 5 years ago
Closed 5 years ago
Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
I feel like in this specific case ValueType doesn't improve the situation very much, because the bit flag system already makes everything kind of annoying. Especially for ValidFlags I would like some ideas on how to do that exhaustively. (i.e. note the gap between JSVAL_TYPE_BIGINT and JSVAL_TYPE_OBJECT that we don't even detect)
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Priority: -- → P1
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cce35becf719 Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub. r=mgaudet
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•