Remove defer usage in devtools/client/shared/widgets/FlameGraph.js
Categories
(DevTools :: Shared Components, enhancement, P3)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: ivan.menshykov, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
We should use new Promise instead.
|
Reporter | |
Comment 1•5 years ago
|
||
Ivan, would you like to work on this bug?
|
Assignee | |
Comment 2•5 years ago
|
||
Nicolas, Yes. Please assign me to this bug.
|
|
Reporter | |
Comment 3•5 years ago
|
||
it's yours, thanks!
|
|
Assignee | |
Comment 4•5 years ago
|
||
Change the defer function with Promise
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
Revert the line that was unnecessary deleted
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 6•5 years ago
|
||
Nicolas, I'm sorry. I submit the two patches. I'm trying to update my first patche like describe here: https://docs.firefox-dev.tools/contributing/making-prs.html
I'm not sure what I'm doing wrong.
|
|
Reporter | |
Comment 7•5 years ago
|
||
No worries :)
Did you amend your first commit?
Are you using arc or moz-phab?
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 8•5 years ago
|
||
Yes, I amended my first commit. And after I did arc diff.
|
|
Reporter | |
Comment 9•5 years ago
|
||
okay, i think that when doing an update the arc diff command should have other argument, but I don't know arc much. I'm using https://github.com/mozilla-conduit/review, which is really handy for the mozilla workflow and is pretty straightforward.
|
|
Assignee | |
Comment 10•5 years ago
|
||
OK, Thank you. I will check it.
|
||
Comment 11•5 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/234eea780806 Remove defer usage in FlameGraph. r=nchevobbe.
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
Description
•