1534467 - layout-debugger no longer builds in non-DEBUG builds

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Mats Palmgren (inactive)]

STR

1. add the following lines to your .mozconfig and rebuild:
   ac_add_options --disable-debug
   ac_add_options --enable-layout-debugger
   export DEBUG_FRAME_DUMP=1
   mk_add_options DEBUG_FRAME_DUMP=1

ACTUAL RESULTS

6:44.47 In file included from /md1/objdir/md1/src/inbound/layout/tools/layout-debug/src/Unified_cpp_layout-debug_src0.cpp:20:
6:44.47 /md1/src/inbound/layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp:107:14: error: unknown type name 'nsILayoutDebugger'; did you mean 'nsLayoutDebugCLH'?
6:44.47 nsCOMPtr<nsILayoutDebugger> ld = do_GetService(kLayoutDebuggerCID);
6:44.47 ^~~~~~~~~~~~~~~~~
6:44.47 nsLayoutDebugCLH
6:44.47 ../../../../../../../../src/inbound/layout/tools/layout-debug/src/nsLayoutDebugCLH.h:20:7: note: 'nsLayoutDebugCLH' declared here
6:44.47 class nsLayoutDebugCLH : public ICOMMANDLINEHANDLER {
6:44.47 ^
6:44.47 In file included from /md1/objdir/md1/src/inbound/layout/tools/layout-debug/src/Unified_cpp_layout-debug_src0.cpp:20:
6:44.47 /md1/src/inbound/layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp:109:11: error: no member named 'GetShowFrameBorders' in 'nsLayoutDebugCLH'
6:44.48 ld->GetShowFrameBorders(&mVisualDebugging);
6:44.48 ~~ ^
6:44.48 /md1/src/inbound/layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp:110:11: error: no member named 'GetShowEventTargetFrameBorder' in 'nsLayoutDebugCLH'
6:44.48 ld->GetShowEventTargetFrameBorder(&mVisualEventDebugging);
6:44.48 ~~ ^
6:44.48 /md1/src/inbound/layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp:141:12: error: unknown type name 'nsILayoutDebugger'; did you mean 'nsLayoutDebugCLH'?
6:44.48 nsCOMPtr<nsILayoutDebugger> ld = do_GetService(kLayoutDebuggerCID);
6:44.48 ^~~~~~~~~~~~~~~~~
6:44.48 nsLayoutDebugCLH

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Chris, wanna take a look at this? Probably just a matter of removing the #ifdef or changing them for #ifdef MOZ_LAYOUT_DEBUGGER.

Comment 2

[Chris Peterson [:cpeterson]]

Sorry. I will fix this.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1534467 - Fix layout debugger build in non-DEBUG builds. r?emilio

Comment 4

[Chris Peterson [:cpeterson]]

btw, is the layout debugger expected to work in non-DEBUG builds? The nsLayoutDebugger class definition and NS_NewLayoutDebugger() factory function were #ifdef DEBUG even before my #ifdef changes in nsILayoutDebugger.h:

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/layout/base/nsLayoutDebugger.cpp#25-26,44

So I would be surprised if do_GetService(kLayoutDebuggerCID) returned a usable object in non-DEBUG builds (though I haven't tested this):

https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp#107

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb30a402bce
Fix layout debugger build in non-DEBUG builds. r=emilio

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bfb30a402bce