1540522 - make datepicker and timepicker work even if there's no menulist already set up

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/source/calendar/resources/content/datetimepickers/datetimepickers.js#9 implies if there is no menulist defined, we won't set up the picker either.

https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/calendar/resources/content/datetimepickers/datetimepickers.js#1111

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1540522_ensure_datepicker.patch

Making sure menu-list editable is always set up, then there is no need for the whenDefined.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9057831 [details] [diff] [review]
bug1540522_ensure_datepicker.patch

I quite liked my `whenDefined` solution, but I'm glad we now understand why it seemed necessary.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/552dd1355efa
make datepicker and timepicker work even if there's no menulist already set up. r=darktrojan