1542646 - Fix issues found by mach static-analysis check

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 1 - forward declaration of DOMSVGAnimatedPreserveAspectRatio is in the wrong namespace

Comment 2

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 2 - use default keyword instead of empty constructors and destructors

Comment 3

[Robert Longson [:longsonr]]

Part 2 is

cd dom/svg
sed -i "" "s|() {}|() = default;|" *.h

with a couple of changes reverted

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe062eac74d9
Part 1 - Correct namespace of forward declaration of DOMSVGAnimatedPreserveAspectRatio r=dholbert

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/323ed046cecd
Part 2 - Use default keyword instead of empty constructors and destructors r=dholbert

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fe062eac74d9
https://hg.mozilla.org/mozilla-central/rev/323ed046cecd

Comment 7

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 3 - forward declaration of DOMSVGAnimatedNumberList is in the wrong namespace

Comment 8

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 4 - use nullptr rather than NULL

Comment 9

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 5 - don't use instance variables to access static methods

Comment 10

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 6 - pass by reference when it's more efficient

Comment 11

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 7 - use default keyword where possible

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f3de2533c4a
Part 3 - forward declaration of DOMSVGAnimatedNumberList is in the wrong namespace r=dholbert

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/550e2e142615
Part 4 - use nullptr rather than NULL r=dholbert

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f612b35ee514
Part 5 - don't use instance variables to access static methods r=dholbert

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c506542937a1
Part 6 - pass by reference when it's more efficient r=dholbert

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1f3de2533c4a
https://hg.mozilla.org/mozilla-central/rev/550e2e142615
https://hg.mozilla.org/mozilla-central/rev/f612b35ee514
https://hg.mozilla.org/mozilla-central/rev/c506542937a1

Comment 17

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 8 - don't call std:move on trivially copyable objects

Comment 18

[Robert Longson [:longsonr]]

Part 8 is mechanical i.e.

sed -i "" "s/std::move(atts)/atts/" SVGFE*.cpp

Comment 19

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 9 - No else after return

Comment 20

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 10 - simplify boolean logic

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/323cc63a9c2d
Part 7 - use default keyword where possible r=dholbert

Comment 22

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/323cc63a9c2d

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb46f41277c
Part 9 - Fix else after return r=dholbert

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f243d937420
Part 10 - simplify boolean logic r=dholbert

Comment 25

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9bb46f41277c
https://hg.mozilla.org/mozilla-central/rev/8f243d937420

Comment 26

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 11 - add explicit to constructor

Comment 27

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 12 - avoid implicit double to float conversions by using std:: variants of mathematical functions

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc36dfcb6cf
Part 11 - add explicit to constructor r=dholbert

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3638ca566d88
Part 11 - add explicit to constructor r=dholbert

Comment 30

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3638ca566d88

Comment 31

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=242693106&revision=4c7bc16c6caf2d770ba17f8a5fc2978d34bca988

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12a4b6b72645
Part 12 - avoid implicit double to float conversions by using std:: variants of mathematical functions r=dholbert

Comment 33

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/12a4b6b72645

Comment 34

[Robert Longson [:longsonr]]

Attachment: Bug 1542646 Part 13 - Make function declaration and definition parameter names match r=dholbert

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1181d18ea08c
Part 13 - Make function declaration and definition parameter names match r=dholbert

Comment 36

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1181d18ea08c

Comment 37

[Robert Longson [:longsonr]]

I've not fixed everything but this is probably enough for one bug.