154681 - tree and listbox shouldn't use search for keyboard navigation

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

When a tree or listbox has focus some keys don't behave including these three:
Error: unterminated parenthetical (
Error: unterminated character class [
Error: trailing \ in regular expression
Error: invalid quantifier {
The errors appear on the JS console when the appropriate key is pressed.
These and other regexp characters don't work as expected.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Jan Varga [:janv]]

cc'ing kyle

Comment 3

[Kyle Yuan]

-           else {
-             if (this._incrementalString.length != 1 || 
this._incrementalString.charAt(0) != key.charAt(0))
-               this._incrementalString += key;
-           }
+           else if (this._incrementalString != key)
+             this._incrementalString += key;

This fix has problem when user repeats pressing a same key, and it doesn't 
cause the JS exception.

Everything else is excellent! My original fix has low efficient and wrong 
string code. Good fix!

Comment 4

[Kyle Yuan]

Oh, forget my previous comment. I'm an idiot.

Comment 5

[Kyle Yuan]

Comment on attachment 89446 [details] [diff] [review]
Proposed patch

r=kyle

Comment 6

[Kyle Yuan]

fixed by bug 192346! thanks for neil's fix!

Comment 7

[Matthias Versen [:Matti]]

Comment on attachment 89446 [details] [diff] [review]
Proposed patch

removing obsolete review request. Did this patch no review before the checkin ?

Comment 8

[Kyle Yuan]

Matti, this patch has been combined into the fix for bug 192346 that got
r=jkeiser and sr=henry.jia.