154708 - Need to refresh icons on upgrade

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Curt Patrick (gone)]

We discovered that new icons are not showing up on some systems when we upgrade
over old icons.  Sean has created a patch to fix this which I will attach.

Comment 1

[Curt Patrick (gone)]

Attachment: Mozilla Patch 1

Comment 2

[Curt Patrick (gone)]

Attachment: NS Patch 1

Comment 3

[Curt Patrick (gone)]

Comment on attachment 89472 [details] [diff] [review]
Mozilla Patch 1

Since this patch was created by ssu, I guess I can do the review.
r=curt

Comment 4

[Curt Patrick (gone)]

Comment on attachment 89473 [details] [diff] [review]
NS Patch 1

r=curt

Comment 5

[Curt Patrick (gone)]

Moving all cc list over from bugscape bug #16868.

Comment 6

[Curt Patrick (gone)]

Comment on attachment 89472 [details] [diff] [review]
Mozilla Patch 1

Transfering this from the bugscape bug:
sr=dveditz

Comment 7

[Curt Patrick (gone)]

Comment on attachment 89473 [details] [diff] [review]
NS Patch 1

Transfering this from the bugscape bug:
sr=dveditz

Comment 8

[Paul Wyskoczka]

Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch.  When you
check this into the branch, please change the mozilla1.0.1+ keyword to fixed1.0.1

Comment 9

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 10

[Curt Patrick (gone)]

Checked in to trunk and branch for both mozilla and ns.

Comment 11

[Grace Bush]

verified on branch 2002070108
trunk 2002070204

Comment 12

[Gregg Landskov (gone)]

Evelyn is reporting that this is not fixed yet.  We may need to reopen.  Grace -
can you follow up with Evelyn?

Comment 13

[Evelyn Prime-MacAdam]

I'm using yesterday's branch build and run Win2k.  My Mail and IM desktop icons
are still the "older" square ones, which I believe are outdated.  I did not
uninstall the previous build before installing yesterday's.  I did a Recommended
install.

Comment 14

[scottputterman]

removing verified1.0.1 to reopen the bug on the branch based on Evelyn's
comments (and others who have mentioned the same thing).  If this also hapepns
on the branch, please reopen the bug.

Comment 15

[Grace Bush]

Evelyn,

Can I come by and see what is happening on your machine?  I cannot reproduce
this on my 2k machine.

Comment 16

[Paul Wyskoczka]

Reopening because of problems on win2k

Comment 17

[scottputterman]

I have a Win 2K machine that I just updated for the first time in a few months.
 The mail and IM icons didn't refresh for me either.  The browser icon worked fine.

Comment 18

[Grace Bush]

not able to reproduce now- saw what was happening on Evelyn's machine- Browser 
icon gets updated but not Mail or IM. 
I tried to reinstall PR1, but get the new icons each for Mail and IM each  time 
I do get the old Browser icon.  

Comment 19

[Daniel Veditz [:dveditz]]

If you're still getting the new icons when you install the old build then you do
have the problem, and you'll have to clear it before you can test the upgrade
again. ssu attached a little utility to one of these bugs (or maybe mail) that
will do it, or you can find TweakUI and clear it.

The difference between the executable and everything else is that the executable
contains an icon internally while the others reference separate .ico files. The
caching appears to handle those cases differently.

Comment 20

[Sean Su]

Attachment: UpdateIcon.exe - utility to refresh desktop icons under Win2k and WinXP

Comment 21

[Sean Su]

by the way, my patch in bug 155025 *does* work for .exe files and shortcuts, but
only under Win2k.  That patch does not work under WinXP.

Comment 22

[Sean Su]

Attachment: UpdateIcon2.exe - utility to refresh icons. does not work under WinXP, only Win2k

This .exe uses the patch in bug 155025 to refresh the desktop icons.  It works
under Win2k, but not WinXP.

Comment 23

[scottputterman]

I rebooted my Win2K machine for the first time since I installed the build with
the new icons.  Now the icons are correct.

Comment 24

[Curt Patrick (gone)]

Attachment: Mozilla Patch 2

Since the new functionality is sorting icons we need to turn it off for
mozilla.  Mozilla is not dependant upon this funtionality at this time, and
Netscape came up with an install script solution that has not impact on
mozilla.

Comment 25

[Daniel Veditz [:dveditz]]

Comment on attachment 91450 [details] [diff] [review]
Mozilla Patch 2

sr=dveditz

Shouldn't we eventually back out the code that didn't work instead?

Comment 26

[Sean Su]

Comment on attachment 91450 [details] [diff] [review]
Mozilla Patch 2

r=ssu

I think it's safer this way for right now (less change).  Perhaps removing it
on the trunk is best, but not on the branch.

Comment 27

[Curt Patrick (gone)]

I created bug #157666 to remind us to back the obsolete code out.

Comment 28

[scottputterman]

I just wanted to verify that if this gets checked in the Netscape build will
still do what want it to?

Comment 29

[Daniel Veditz [:dveditz]]

It's currently *not* doing what we want it to, this latest change at least stops
it from doing what we DON'T want it to. There's another bug (bugscape) that gets
the effect you're after in commercial.

Comment 30

[scottputterman]

It sounds like this doesn't affect the ns build since bugscape 16868 covers the
work for that.  So I'm removing mach v tracking kewyords.

Comment 31

[Asa Dotzler [:asa]]

Comment on attachment 91450 [details] [diff] [review]
Mozilla Patch 2

a=asa (on behalf of drivers) for checkin to 1.1

Comment 32

[Curt Patrick (gone)]

Checked in to mozilla trunk.  Can I close this, or does this need to be checked
in to MOZILLA_1_0_BRANCH?  I'm not clear on that.

Comment 33

[Sean Su]

you can close this bug as fixed if the patch has been checked into the trunk.

Add keyword fixed1.0.1 when checked into the branch.

Comment 34

[Curt Patrick (gone)]

Duh.

Comment 35

[Jaime Rodriguez, Jr.]

has this been checked into the 1.0 branch? if not, we need to get it in asap.

gbush: can you verify this on the trunk?

Comment 36

[Syd Logan]

Please get this into the branch. Added adt1.0.1+

Comment 37

[Grace Bush]

verified trunk 2002071908

Comment 38

[chris hofmann]

a=chofmann for the 1.0.1 branch as well

Comment 39

[Curt Patrick (gone)]

Checked in to 1.0.1 branch

Comment 40

[Grace Bush]

branch build 2002072308 on Win 2k machine