154769 - Mozilla can't animate this broken image

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Adam Hauner]

Mozilla can't animate broken image, but other browsers (MSIE5.0, Opera 6.x,
NN4.79) are able to do it. Mozilla IMHO should also support this sometime in far
future. =)

2002062308/trunk/W2k

Comment 1

[Boris Zbarsky [:bzbarsky]]

paper, this seems like your thing... ;)

Comment 2

[Sören 'Chucker' Kuklau (gone)]

Confirming under Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1a+)
Gecko/20020619, but why should Mozilla be able to display broken images? If it's
broken, fix it.

Comment 3

[Michael Lefevre]

confirming with 1.1beta on win2k.

IE also animates the broken gif (with some corruption on one of the frames).

this could be a wontfix, but that's not my call...

Comment 4

[ArronM (:paper)]

*** Bug 195523 has been marked as a duplicate of this bug. ***

Comment 5

[ArronM (:paper)]

Attachment: Finish up Decoding

Never saw this bug before until today.. bugmail must have slipped under my
nose.  Sorry.

Here's a patch.  Upon recieving a Close notification from the stream, this
patch closes off a GIF frame if one is still open, and then it closes off the
GIF if the GIF is still open.

Comment 6

[ArronM (:paper)]

Another Testcase (from dup'd bug):
http://bugzilla.mozilla.org/attachment.cgi?id=115976&action=view

Comment 7

[ArronM (:paper)]

Attachment: Finish Up Decoding

Now less fuzzy

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 116285 [details] [diff] [review]
Finish Up Decoding

+  : mImageContainer(nsnull)
+  , mImageFrame(nsnull)
+  , mObserver(nsnull)

No need to explicitly initialize these to nsnull (it's a nsCOMPtr, which are
nsnull by default). Remove this initialization, and r=biesi.

Comment 9

[tor]

Comment on attachment 116285 [details] [diff] [review]
Finish Up Decoding

Make mGIFOpen a PRPackedBool, do biesi's tidying, and sr=tor.

Comment 10

[ArronM (:paper)]

Attachment: Checked-In Patch

This is the patch I'll check in.

Don't worry about r+/sr+

Comment 11

[ArronM (:paper)]

checked in