154853 - added bookmarks don't appear at the end of the menu

Status: VERIFIED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[sairuh (rarely reading bugmail)]

i thought that this was erratic with older builds, but i can reproduce this with
2002.06.27.05 chimera bits.

1. hit cmd+D to add a bookmark (eg, while viewing the bugzilla query page).
2. edit the Name field in the Bookmark dlg (optional, really). hit OK.
3. pull down the Bookmarks menu

results: the added bookmark is not at the bottom of the menu (as would be
expected), but is instead 4th from the bottom.

4. repeat adding another bookmark, and look at the menu again.

results: again, the most recently added bookmark is 4th from the bottom (the
previously added one is 5th from the bottom).

interestingly, when looking at the bookmarks tab in the Sidebar, the order of
the bookmarks is fine --last ones at the bottom.

Comment 1

[sairuh (rarely reading bugmail)]

another interesting thing: after quitting and restarting, the order of the
bookmarks menu is "reset" --ie, it then looks fine (recently added items at the
bottom).

Comment 2

[Simon Fraser [no longer active]]

I know why this happens.

Comment 3

[sairuh (rarely reading bugmail)]

note: if, while in the bookmarks dlg, i place the new bookmark in a folder, i
don't see this problem --ie, the new bm appears at the bottom of that folder's
submenu.

Comment 4

[Simon Fraser [no longer active]]

Yeah, this only affects the top-level menu. The new item is added N items too
high in the menu, where N is the number of 'permanent' items (above and
including the separator) in the menu.

Comment 5

[Simon Fraser [no longer active]]

Fix checked in.

Comment 6

[Winnie Lam]

Verified with 07-01 build on OS 10.1.5.  Added two bookmarks and both were
placed at the bottom of the menu in order.  Also placed in the right order in
the sidebar.  Upon quitting and relaunching chimera, these two bookmarks are
still in the same right places.