1550757 - Create new DLL for sharing VR code

Status: VERIFIED FIXED

(Core :: WebVR, enhancement, P2)

Comment 1

[thomasmo]

Attachment: Bug 1550757 - Create new DLL for sharing VR code

This change introduces a new dll, vrhost, to make it easier to share
VR code across multiple process.
An executable, vrtesthost, is also added for testing purposes to
validate the DLL loads in a minimal environment.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af0fd51dc41a
Create new DLL for sharing VR code r=kip

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset af0fd51dc41a (Bug 1550757) for vrhost related mingw bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=2c73bd0fae85c2e877932e9f98ffd28fe91538f1&searchStr=windows%2Cmingw%2Call%2Cmingw-clang%2Cbuilds&tochange=76bbedc1ec1ae367906390c01a8ca008d7944cac&selectedJob=246523233

Backout link: https://hg.mozilla.org/integration/autoland/rev/76bbedc1ec1ae367906390c01a8ca008d7944cac

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246523233&repo=autoland&lineNumber=18882

[task 2019-05-15T04:57:23.461Z] 04:57:23 INFO - Creating Resource file: module.res
[task 2019-05-15T04:57:23.461Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.467Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers/apz/test/gtest'
[task 2019-05-15T04:57:23.469Z] 04:57:23 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/x86_64-w64-mingw32-clang++ -mwindows -o Unified_cpp_apz_test_gtest0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/layers/apz/test/gtest -I/builds/worker/workspace/build/src/obj-firefox/gfx/layers/apz/test/gtest -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/gfx/2d -I/builds/worker/workspace/build/src/gfx/layers -I/builds/worker/workspace/build/src/gfx/tests/gtest -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fms-extensions -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -mms-bitfields -Wno-incompatible-ms-struct -fno-rtti -ffunction-sections -fdata-sections -Wa,-mbig-obj -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O1 -fno-omit-frame-pointer -funwind-tables -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_apz_test_gtest0.o.pp /builds/worker/workspace/build/src/obj-firefox/gfx/layers/apz/test/gtest/Unified_cpp_apz_test_gtest0.cpp
[task 2019-05-15T04:57:23.469Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers/apz/test/gtest'
[task 2019-05-15T04:57:23.472Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/harfbuzz/src'
[task 2019-05-15T04:57:23.474Z] 04:57:23 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/x86_64-w64-mingw32-clang++ -mwindows -o hb-ot-shape.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -UDEBUG '-DPACKAGE_VERSION="moz"' '-DPACKAGE_BUGREPORT="http://bugzilla.mozilla.org/"' -DHAVE_OT=1 -DHAVE_ROUND=1 -DHB_NO_MT -DHB_NO_UNICODE_FUNCS -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/gfx/harfbuzz/src -I/builds/worker/workspace/build/src/obj-firefox/gfx/harfbuzz/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fms-extensions -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -mms-bitfields -Wno-incompatible-ms-struct -fno-rtti -ffunction-sections -fdata-sections -Wa,-mbig-obj -fno-exceptions -fno-math-errno -pipe -g -gcodeview -O1 -fno-omit-frame-pointer -funwind-tables -MD -MP -MF .deps/hb-ot-shape.o.pp /builds/worker/workspace/build/src/gfx/harfbuzz/src/hb-ot-shape.cc
[task 2019-05-15T04:57:23.474Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/harfbuzz/src'
[task 2019-05-15T04:57:23.475Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/harfbuzz/src'
[task 2019-05-15T04:57:23.475Z] 04:57:23 INFO - gfx/harfbuzz/src/Unified_cpp_gfx_harfbuzz_src0.o
[task 2019-05-15T04:57:23.475Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/harfbuzz/src'
[task 2019-05-15T04:57:23.476Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/config'
[task 2019-05-15T04:57:23.476Z] 04:57:23 INFO - mkdir -p '.deps/'
[task 2019-05-15T04:57:23.476Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/config'
[task 2019-05-15T04:57:23.476Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/config'
[task 2019-05-15T04:57:23.476Z] 04:57:23 INFO - gfx/config/Unified_cpp_gfx_config0.o
[task 2019-05-15T04:57:23.477Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/config'
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - /builds/worker/workspace/build/src/clang/bin/x86_64-w64-mingw32-windres -O coff --use-temp-file -DDEBUG=1 --include-dir /builds/worker/workspace/build/src/gfx/vr/vrhost --include-dir /builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost --include-dir /builds/worker/workspace/build/src/obj-firefox/dist/include -o module.res /builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost/module.rc
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - gfx/vr/vrhost/vrhost.dll
[task 2019-05-15T04:57:23.492Z] 04:57:23 INFO - rm -f vrhost.dll
[task 2019-05-15T04:57:23.493Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.516Z] 04:57:23 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.516Z] 04:57:23 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/x86_64-w64-mingw32-clang++ -mwindows -shared -Wl,--gc-sections -Wl,--out-implib -Wl,libvrhost.a -Wl,-pdb,vrhost.pdb -o vrhost.dll vrhost.o ./module.res -Wl,-S -Wl,--dynamicbase -Wl,--icf=safe ../../../../gfx/vr/vrhost/vrhost.def -luuid -lusp10 -lgdi32 -lwinmm -lwsock32 -luserenv -lsecur32
[task 2019-05-15T04:57:23.516Z] 04:57:23 INFO - lld-link: error: <root>: undefined symbol: SampleExport
[task 2019-05-15T04:57:23.516Z] 04:57:23 INFO - clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2019-05-15T04:57:23.516Z] 04:57:23 INFO - /builds/worker/workspace/build/src/config/rules.mk:689: recipe for target 'vrhost.dll' failed
[task 2019-05-15T04:57:23.516Z] 04:57:23 ERROR - make[4]: *** [vrhost.dll] Error 1
[task 2019-05-15T04:57:23.517Z] 04:57:23 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/vr/vrhost'
[task 2019-05-15T04:57:23.518Z] 04:57:23 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'gfx/vr/vrhost/target' failed
[task 2019-05-15T04:57:23.518Z] 04:57:23 ERROR - make[3]: *** [gfx/vr/vrhost/target] Error 2
[task 2019-05-15T04:57:23.518Z] 04:57:23 INFO - make[3]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83a094f31fb0
Create new DLL for sharing VR code r=kip

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/83a094f31fb0

Comment 6

[thomasmo]

clearing needinfo, this bug has been resolved.