155109 - Save As Complete misplaces data: src

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load the testcase.
2. Save As, select "Web Page, complete", and type "a222" as the filename.
3. Load the saved page.

Result: the data: url in the iframe src is replaced by
<iframe src="a222_files/.html"></iframe> and the iframe src is saved as
a222_files/_001.html.

Expected: either leave the iframe src as a data: url (preferred) or put the
correct filename in the saved source.

Comment 1

[Jesse Ruderman]

Attachment: testcase using iframe

Comment 2

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

Patch v1.

I'll do with what Jesse has said here, don't save the data: URI's. It could contain a HTML document for example but it could equally contain just about anything else. We don't save things like the javascript: URI's so why bother with the data URI's?

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

That's just my opinion. It seems like a lot of worth otherwise. We'll need to take the content type presented and generate a correct file extension and a name for the file is saved. It seems like unnecessary work when we could also claim that javascript URI's could be saved to .js files in the same way.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 255343 [details] [diff] [review]
Patch v1

Sure.

Comment 5

[Nickolay_Ponomarev]

mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp  1.123