Closed
Bug 156606
Opened 22 years ago
Closed 20 years ago
Identify pages viewed as source in title
Categories
(Camino Graveyard :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino0.8
People
(Reporter: sagemane+bugzilla, Assigned: mikepinkerton)
References
()
Details
Attachments
(2 files, 1 obsolete file)
2.60 KB,
patch
|
Details | Diff | Splinter Review | |
1.44 KB,
patch
|
Details | Diff | Splinter Review |
In Chimera/20020709 on Mac OS 10.1.5, if you view the source of a page in a new window or tab, the title of the source's window or tab is the URL of the page you are viewing the source of, but it does not identify itself as being source code in the title. For example, if you go to apple.com and view the source, the title of the source window or tab will be, "http://www.apple.com/". It would be more clear if the window were named, "Source of http://www.apple.com" Mozilla names source windows "Source of: http://www.somewebsite.com - Mozilla" so this is a Chimera-specific issue.
Confirmed using Chimera/20020708. Steve's suggestion is a good one (but let's not append "- Chimera" à la Mozilla here).
Updated•22 years ago
|
Summary: [RFE] Identify pages viewed as source in title → Identify pages viewed as source in title
Comment 2•22 years ago
|
||
Adds localizable 'Source of ' before view-source tabs and windows.
Bump. Could this land, seems like a very simple solution to something that might irritate people.
Mike I'm putting this on the 0.8 list since it's such a nice patch. I have been running this patch i one of David Haas's builds and never encountered problems. It's a small detail just like the one that changes the window title when in Bookmarks view mode. Reset as needed.
Target Milestone: --- → Camino0.8
Assignee | ||
Comment 8•21 years ago
|
||
this patch isn't l10n savvy, but it should be easy to make it so. working on it and will land.
Assignee: sfraser → pinkerton
Assignee | ||
Comment 9•21 years ago
|
||
cleaned up and landed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 10•21 years ago
|
||
Pretty big problem... Load your home page, select view source from the menu, then flip back and forth from the source page and the original a few times. Notice that the title of the source view tab gets "Source of " prefixed to it multiple times. Shouldn't be too hard to fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 11•21 years ago
|
||
This patch fixes the problem where "Source of " duplicates when tabbing and cleans up the code for the entire method in charge of that.
Comment 12•21 years ago
|
||
I found out that my patch causes this failure when switching back and forth between the original and source view tabs: 2004-02-18 16:41:06.452 Camino[12200] *** Assertion failure in -[BrowserWindow setTitle:], AppKit.subproj/NSWindow.m:1490 2004-02-18 16:41:06.523 Camino[12200] Invalid parameter not satisfying: aString != nil I don't have time to fix it now, but I will in a bit if nobody else does.
Comment 13•20 years ago
|
||
Attachment #141697 -
Attachment is obsolete: true
Assignee | ||
Comment 14•20 years ago
|
||
landed patch with tweaks.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•