156791 - UI Strings in JavaScript content area should be moved to locale

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[ajbu]

There are still hardcoded UI strings in the Calendar JavaScript, those should 
be moved to locale properties to enable translation.
Would it be easiest if I comment those strings here when I see them?
Put them all in different bugs seems a little cumbersome.

Comment 1

[ajbu]

Strings in calendarMail.js:
 nsIMsgAttachment.name = "iCal Event"
 nsIMsgCompFields.subject = gMailIdentity.fullName + " would like to schedule 
a meeting with you";
 nsIMsgCompFields.organization = gMailIdentity.organization;
 nsIMsgCompFields.body = "When: " + Event.start + "-" + Event.end 
+ "\nWhere: " + Event.location + "\nOrganizer: " + gMailIdentity.fullName + " 
<" + gMailIdentity.email + ">" + "\nSummary:" + Event.description;

Comment 2

[Julien Balas]

strings concerned
--------
in the Daily view 
"All-Day Events" 
--------
in the Calendar global setting
"Calendar" in the window title
"Date Text Format" 
The combo whith 
"Short Format (ie. 04/01/02)" and
"Long (ie. Apr 1, 2002)"
"First Day Of The Week" and The list of Days just after.
"Default Event Length" 
(and may be "Minutes" juste after but it's the same name in french)
"Default Snooze Length"
(and may be "Minutes" juste after but it's the same name in french)
--------
"Go" menu
"Next" and "Previous" item in the "Go" Menu

Best regards

Comment 3

[ajbu]

Attachment: patch for pref local strings + categories

Patch to move pref dialog text to locale dtd. 
Patch also adds simple categories field to the pref page.

Comment 4

[ajbu]

Attachment: patch to localize Go menu

Comment 5

[Mike Potter]

Checked into CVS.

Comment 6

[ajbu]

This are the strings I know of are still in the JavaScript:

calendarMail.js
[194]			nsIMsgAttachment.name = "iCal Event"
[206]			nsIMsgCompFields.body = "When: " + Event.start + "-" + 
Event.end + "\nWhere: " + Event.location + "\nOrganizer: " + 
gMailIdentity.fullName + " <" + gMailIdentity.email + ">" + "\nSummary:" + 
Event.description;


calendarDayView.js
[151]      TextNode = document.createTextNode( "All-Day Events" );
note that calendarWeekView uses the label from global.dtd:
<!ENTITY allDayEvents.label "All Day Events">

calendarImportExport.js also has hardcoded strings for filters and dialogs.

Comment 7

[Mike Potter]

Fixed all except for the strings in calendarImportExport.js

Comment 8

[Brant Gurganus]

Default QA Contact for Calendar has changed.  If you wish to remain the QA
contact for this bug, feel free to change it back.

Comment 9

[Mike Potter]

Fixed the ones in importExport.js now.
This should be done.

Comment 10

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!