158245 - Page info should list the alt for images in the media-tab in the tree.

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Nicolás Lichtmaier]

It was very handy to easily check which images had alt attributes and which
images lacked one of those.

Comment 1

[Nicolás Lichtmaier]

Attachment: Patch v1.0

I've added a new row to the <tree>, I've made it hidden by default.

This is the first XUL patch I ever contribute to Mozilla! =)

Comment 2

[Nicolás Lichtmaier]

Attachment: v1.1: Removed extra colon

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 91919 [details] [diff] [review]
v1.1: Removed extra colon

Use hasAttribute() to test attribute existence.

Comment 4

[Nicolás Lichtmaier]

Attachment: Uses hasAttribute. Fixes bug in detailed view.

I've found a bug in the detailed view. An alt="", isn't the same as "not
specified", but as "" evaluates to false it regards such alt attribute as
non-existant.

Comment 5

[Nicolás Lichtmaier]

Attachment: Ops! Uses hasChildNodes().

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 91996 [details] [diff] [review]
Ops! Uses hasChildNodes().

>+  if(item.hasAttribute("alt"))
>+    altText = item.alt;

This is no good.  <div alt="foo"> will test true for hasAttribute("alt") and
give a strict warning with that code.  You need to test both
hasAttribute("alt") and |"alt" in item|

also, space between "if" and "(" please, here and right after that.

Comment 7

[Nicolás Lichtmaier]

Attachment: Shows an italic "empty string" for alt="" in detailed view

Well.. I'll stop addding things so this can be reviewed and (hopefully) checked
in.. =)

Comment 8

[Boris Zbarsky [:bzbarsky]]

> +  if (altText=="") {

If this is true, that means alt text is set.  Why does it matter whether the
textbox is italic if its contents are the empty string?

Comment 9

[Daniel Brooks [:db48x]]

Comment on attachment 92062 [details] [diff] [review]
Shows an italic "empty string" for alt="" in detailed view

what's with the stars in notSet?

Comment 10

[Boris Zbarsky [:bzbarsky]]

> +emptystring=empty string

Capitalize that, and sr=bzbarsky

Comment 11

[Nicolás Lichtmaier]

Attachment: emptystring -> emptyString

Comment 12

[Nicolás Lichtmaier]

I've filed a new bug, bug 158425 to put all those "Not specified" strings in
italics :).

Comment 13

[Daniel Brooks [:db48x]]

I think he meant "Empty String" :)

Comment 14

[Daniel Brooks [:db48x]]

Also, while you're working on this bug look for the bug where someone asks me to
add all the things that show up in the detail area as (hidden) columns in the
tree. Now that you've got this one under your belt, the others should be a snap.

Comment 15

[Nicolás Lichtmaier]

Taking it as me, as adviced on IRC =).

Comment 16

[Nicolás Lichtmaier]

Attachment: emptyString -> emptystring, "empty string" -> "Empty String"

Hehe.. done.. =)

db48x: sure, It will be nice to have the other values there. Another thing I
was thinking is.. the "no." row is useless for most people, why don't we hide
it by default?

Comment 17

[Daniel Brooks [:db48x]]

Comment on attachment 92070 [details] [diff] [review]
emptyString -> emptystring, "empty string" -> "Empty String"

+  var notSet = "*" + theBundle.getString("notset") + "*"

take the * out of this, and r=db48x

Also, feel free to hide the number column in this and any other tab it's not
hidden by default. I must have forgotten to fix it, I must have hidden them
with the colpicker and forgotten about the bug.

Comment 18

[Nicolás Lichtmaier]

Boo, I liked the starts. The idea was to make that text stand-out from the real
specified text. But that text should be in italic anyway...

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 92070 [details] [diff] [review]
emptyString -> emptystring, "empty string" -> "Empty String"

sr=bzbarsky once db48x's comment is addressed.

Comment 20

[Nicolás Lichtmaier]

Attachment: No more starts, "no." hidden by default.

Done.

Comment 21

[Daniel Brooks [:db48x]]

Comment on attachment 92071 [details] [diff] [review]
No more starts, "no." hidden by default.

yea, r=db48x. who have you asked to check this in?

Comment 22

[Nicolás Lichtmaier]

I've emailed [e-mail], as I read in mozillazine. Besides that I
haven't asked anybody anything...

Comment 23

[Scott Collins]

Comment on attachment 92071 [details] [diff] [review]
No more starts, "no." hidden by default.

a=scc for checkin to the mozilla TRUNK, after 1.1b tag/branch is cut

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in