15845 - Pref UI uses opposite value from 4.x: remember_selected_message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[laurel]

Using 1999-10-07-14m11 NT 4.0 and linux 6.0

mailnews.remember_selected_message: Seamonkey appears to be using the pref
value in reverse/opposite to engage the prefs UI.  So, a value for the pref
which would cause the pref to display enabled in 4.x will cause it to display
disabled in 5.0.

This affects migration in that the migrated pref UI displays the opposite
enabled/disabled state after migration.

1.  In 4.x communicator, disable/uncheck the mailnews.remember_selected_message
pref.
This is accessible via Edit|Preferences|Mail and Newsgroups and is located
toward the bottom of the mail and newsgroups pref panel. Confirm OK, exit
communicator.
2.  Check the 4.x prefs.js file and notice the pref value reflecting disabled
state in 4.x: user_pref("mailnews.mailnews.remember_selected_message", false)
3.  Migrate that profile to seamonkey.
4.  Launch Messenger and open the prefs dialog and check the UI's state of the
pref -- it is checkmarked/enabled. This is opposite 4.x
5.  Check the seamonkey prefs.js file and notice the value for the pref is still
listed false.  Exit and relaunch doesn't shift the prefs.js or UI value in
seamonkey.
6.  Create a new profile in seamonkey and enable the pref. Double-check that the
pref indeed does stick as enabled in the UI after exit.
7.  Check the new profile's prefs.js file and notice the value for the pref is
false, which is opposite the 4.x translation for enabled.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting bug.

Comment 2

[Phil Peterson]

M12

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.

PrefWindow now supports "reversed" on checkboxes.

I stole the "reversed" idea from alecf's account manager.

Comment 4

[laurel]

This is OK for the case of setting pref state with 5.0 ui.  Marking this
verified. However, there is a problem with migration if the 4.x value is true,
which has been logged in bug #23370.

OK using 2000-01-06-08 commercial NT 4.0
OK using 2000-01-06-08 mozilla linux 6.0
OK using 2000-01-06-11 mac OS 8.5.1