15904 - Problems with text manipulation on comment nodes

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  There are serious problems using the CharacterData interfaces on
comment nodes.  Basically, any call to insertData(), appendData(), or
deleteData() causes the first character in the comment to disappear.

STEPS TO REPRODUCE:
 * load http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Comment
 * run tests

ACTUAL RESULTS:  Lots of red.  Each progressive actual result after the first
section has one fewer character at the beginning.

EXPECTED RESULTS:  Green.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-08-08-M11

ADDITIONAL INFORMATION:
In XML, the problem even shows up for the *initial value* of Comment::data.  See
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-xml/Comment

Comment 1

[vidur (gone)]

Assigning to Waqar for initial investigation.

Comment 2

[waqar]

A fixed checked in. The problem now is Kipps code changes for
nsGenericDOMDataNode::AppendData method. With my changes and the old code it
works fine. Then change I made was to nsCommentNode.cpp.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See bug 6071.

Comment 4

[waqar]

Fix checked in.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Reopening this one based on Linux mozilla 1999-11-13-08-M12. There's still
something wrong with appendData. That's why two lines in the test page are still
red.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Reopening this one based on Linux mozilla 1999-11-13-08-M12. There's still
something wrong with appendData. That's why two lines in the test page are still
red.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There is also a problem visible in (the second button of)
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Document .  Could this
have something to do with one-byte versus two-byte characters?

Comment 8

[waqar]

Fix checked in.

Comment 9

[Jan Carpenter]

Mass update of qa contact

Comment 10

[Prashant Desale]

QA contact Update

Comment 11

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 12

[Sivakiran Tummala]

verified...i do not see any red lines in the testcases