15909 - line breaking on ' after link with .

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  Currently line breaks are allowed before an ' (apostrophe) that
immediately (with no space) follows an inline element containing a ".", for
example, you are breaking (in the above URL):

<a href="http://www.mozilla.org">mozilla.org</a>'s

as:

mozilla.org
's

when the window is an appropriate width.  This occurs with other inline
elements, such as SPAN, but does not happen if there is no inline element.

STEPS TO REPRODUCE:
 * Load test case (to be attached)
 * make window size so that the lines barely have to be broken.

ACTUAL RESULTS:
 * The word mozilla.org's is broken at the ' in the first and fourth case.  The
cases are as follows:
    1) <a>mozilla.org</a>'s
    2) <a>mozillaorg</a>'s
    3) mozilla.org's
    4) <span>mozilla.org</span>'s

EXPECTED RESULTS:
 * The entire word mozilla.org's should be on the second line in all 4 cases.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-08-08-M11

ADDITIONAL INFORMATION:

I would assume this is a bug, although I don't know if Unicode specifies line
breaking, and if so, what it says.  Perhaps it's worth checking, though.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: test case described in bug

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot (PNG) of test case, showing bug

Comment 3

[Frank Tang]

I try our nsILineBreaker again and I think the bug is not inside nsILineBreaker.
I think the bug is inside nsTextFrame.cpp or other code which call the
nsTextTransformer

Comment 4

[Frank Tang]

Attachment: test case with bigger font size

Comment 5

[Frank Tang]

The problem actually have nothing to deal with ' . The problem is related to
'.'(period) . That is why if there are no . between mozilla and org it will work
fine. Fix check in 1.20 of nsJISx4501LineBreaker.cpp

Comment 6

[Teruko Kobayashi]

I verified this in 2000020808 Win32, 2000020809 Linux, and 2000020410 Mac build.

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/d2f17e81b0ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie (https://github.com/mozilla-mobile/fenix/pull/15909)