159170 - download window progress doesn't stop when saving page as text

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2002.07.24.05 chimera bits.

0. make sure you have the "leave Open" option selected for the download window.
1. go to any web page, eg, http://mozilla.org/
2. hit cmd+S or select File > Save Page As
3. in the resulting file picker, select the format as "plain text"
4. hit Save.

results: the page is saved, but the progress meter in the download window keeps
on animating.

could this be related to the fix for bug 155334?

interestingly, if context-select "save link as" for a text file (or use
cmd+S/File > Save As when viewing a text file), i don't encounter this. (namely,
there's no option for file format.)

Comment 1

[saari (gone)]

->sfraser

Comment 2

[sairuh (rarely reading bugmail)]

this seems more polish than a blocker, since the file is saved.

Comment 3

[Simon Fraser [no longer active]]

Actually, we could argue that this is expected behaviour. The window is
following the setting of the 'Leave open'/'Close when done' button in the
download dialog.

I think we should hide that button for 'Save' operations, and always just close
the dialog.

Comment 4

[sairuh (rarely reading bugmail)]

comment 3: on a related note, also see bug 158751.

Comment 5

[Simon Fraser [no longer active]]

Attachment: Patch to hide the 'leave open' button, and always close the progress dialog, when Saving

Comment 6

[Mike Pinkerton (not reading bugmail)]

bueno. r=pink

Comment 7

[Simon Fraser [no longer active]]

Fix checked in.

Comment 8

[Winnie Lam]

verified with 07-25 build on OS 10.1.5.