159729 - -turbo shouldn't steal focus

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Gili Tzabari]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.1b) Gecko/20020724
BuildID:    2002072408

Running Mozilla -turbo (seemingly) causes it to open up and minimize very
quickly to accomplish its goal.

You shouldn't be poping up anything at all. If I place "mozilla -turbo" in my
startup script it keeps on stealing the focus away from me while I'm typing in
some other window.

Mozilla -turbo should run completely transparent to the end-user and should not
involve any visible GUI components.

Reproducible: Didn't try

Comment 1

[Gili Tzabari]

Correction to title :) changed "should steal focus" to "shouldn't steal focus"

Comment 2

[Mike Kaply [:mkaply]]

Taking

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Part 1 of fix

There are really two problems here.

Problem 1 is that the window comes up at all.

Problem 2 is the focus.

This first patch is the focus issue.

The second patch will be a rewrite of nsNativeAppSupportOS2.cpp to bring our
turbo up to Windows and hence fix the rest of the problems.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Report of nsNativeAppSupportOS2

Every so often we have to report nsNativeAppSupport to get the latest stuff
from windows, especially for turbo mode and DDE.

That's what this is.

This fixes some misc traps with turbo mode, as well as some DDE functions that
weren't working.

It's also some general cleanup of the file to be more like Windows.

Comment 5

[jhp (no longer active)]

Comment on attachment 93454 [details] [diff] [review]
Part 1 of fix

r=pedemont,
sr=blizzard (platform specific code)

Comment 6

[jhp (no longer active)]

Comment on attachment 93455 [details] [diff] [review]
Report of nsNativeAppSupportOS2

if you set MOZ_DEBUG_DDE to 0 instead of one, then:
r=pedemont,
sr=blizzard (platform specific code)

Comment 7

[Mike Kaply [:mkaply]]

Fixes checked in.

Comment 8

[Mike Kaply [:mkaply]]

verified this is fixed.