160672 - [FIX]XP filepicker's modeGetFolder looks too much like modeOpen

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

The error messages could use some work, as could the textfield label

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Something like this

Comment 2

[Boris Zbarsky [:bzbarsky]]

timeless, would you review?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Looks good to me, but I'm no filepicker wizard (though it's pretty
straight-forward).  Brian, would you have time to take a look at this patch? 
This would be great to have for Buffy.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 160591 has been marked as a duplicate of this bug. ***

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 93699 [details] [diff] [review]
Something like this

>--- components/filepicker/res/content/filepicker.js	7 Jul 2002 07:21:34 -0000	1.76
>+++ components/filepicker/res/content/filepicker.js	2 Aug 2002 12:02:51 -0000
>@@ -234,9 +239,16 @@
>     //promptService.alert(window, "Problem", "normalize failed, continuing");
>   }
> 
>-  if (!file.exists() && (filePickerMode != nsIFilePicker.modeSave)) {
>+  if (!file.exists() && (filePickerMode == nsIFilePicker.modeOpen)) {
>     showErrorDialog("errorOpenFileDoesntExistTitle",
>                     "errorOpenFileDoesntExistMessage",
>+                    file);
>+    return false;
>+  }
>+
>+  if (!file.exists() && (filePickerMode == nsIFilePicker.modeGetFolder)) {
>+    showErrorDialog("errorDirDoesntExistTitle",
>+                    "errorDirDoesntExistMessage",
>                     file);
>     return false;
>   }

Uh, let's not check for file.exists() twice here.  something like:

if (!file.exists() && filePickerMode != nsIFilePicker.modeSave) {
  if (filePickerMode == nsIFilePicker.modeOpen) {
    showErrorDialog(...); 
  } else {
    showErrorDialog(...);
  }
  return false;
}

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: patch updated to bryner's comments

Comment 7

[Boris Zbarsky [:bzbarsky]]

keeping on my radar

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: unrot from sspitzer's landing

Yay patch rot.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 98492 [details] [diff] [review]
unrot from sspitzer's landing

>Index: xpfe/components/filepicker/res/content/filepicker.js
>===================================================================
>+  if (filePickerMode == nsIFilePicker.modeGetFolder) {
>+    var textInputLabel = document.getElementById("textInputLabel");
>+    textInputLabel.value = gFilePickerBundle.getString("dirTextInputLabel");
>+  }
>+  

Nittiest of nits:  Kill the spaces on the blank line you're adding.

>-  if (!file.exists() && (filePickerMode != nsIFilePicker.modeSave)) {
>+  var fileExists = file.exists();
>+  

Here too.

>+  if (!fileExists && (filePickerMode == nsIFilePicker.modeOpen ||
>+                      filePickerMode == nsIFilePicker.modeOpenMultiple)) {


r=caillon

Comment 10

[Brian Ryner (not reading)]

Comment on attachment 98492 [details] [diff] [review]
unrot from sspitzer's landing

sr=bryner

Comment 11

[Boris Zbarsky [:bzbarsky]]

fixed.