Closed
Bug 161716
Opened 22 years ago
Closed 22 years ago
stop exporting nsStr
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.2alpha
People
(Reporter: alecf, Assigned: alecf)
Details
Attachments
(1 file)
|
5.37 KB,
patch
|
dougt
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
we're exporting nsStr which means that occasional libraries are picking up random routines from it, and there is really no need - for instance, Layout is importing nsStr::GetCharSize() because it is calling the global GetCharAt(), which should also not be exported. patch forthcoming.
|
Assignee | |
Comment 1•22 years ago
|
||
this stops exporting nsStr, and fixes the one caller who was importing it inadvertently.
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2alpha
|
||
Comment 2•22 years ago
|
||
Comment on attachment 94480 [details] [diff] [review] stop exporting nsStr looks great. r=dougt
Attachment #94480 -
Flags: review+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 94480 [details] [diff] [review] stop exporting nsStr sr=jag
Attachment #94480 -
Flags: superreview+
|
|
Assignee | |
Comment 4•22 years ago
|
||
fix went in recently.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•