Closed
Bug 161890
Opened 22 years ago
Closed 22 years ago
[PATCH] incorrect regexp in ConvertRGBColorIntoHEXColor()
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glazou, Assigned: glazou)
Details
Attachments
(2 files)
|
660 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
|
702 bytes,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The regexp in ConvertRGBColorIntoHEXColor() in file editorUtilities.js in
incorrect. A recent change (or regression) in regexps showed it yesterday.
/rgb\((\d*),*(\d*),*(\d*)\)/
should be read
/rgb\((\d*),\s*(\d*),\s*(\d*)\)/
to accept whitespaces after the commas.
|
Assignee | |
Comment 1•22 years ago
|
||
Attachment #94619 -
Flags: review+
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Summary: incorrect regexp in ConvertRGBColorIntoHEXColor() → [PATCH] incorrect regexp in ConvertRGBColorIntoHEXColor()
Whiteboard: fix in hand, needs sr=
|
|
Assignee | |
Comment 2•22 years ago
|
||
better patch, thanks Neil
|
||
Updated•22 years ago
|
Attachment #94623 -
Flags: review+
|
||
Comment 3•22 years ago
|
||
Comment on attachment 94623 [details] [diff] [review] patch v1.1 sr=bzbarsky if you add \s* before the commas too.
|
|
Assignee | |
Comment 4•22 years ago
|
||
checked in (trunk)
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, needs sr=
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•