16230 - pluglets crash mozilla after reload

Status: VERIFIED FIXED

(Core Graveyard :: Java-Implemented Plugins, defect, P3)

Description

[Igor Kushnirskiy]

How to reproduce:
-Load simple pluglet.
-Press reload
Mozilla crashes

Comment 1

[Igor Kushnirskiy]

The reason of this bug is as follows:
We do not call AddRef for our PlugletInstance.
At some point we have 2 reference to our PlugletInstance, butreferenc counter
equal to 1. So after first release() PlugletInstance would be destroyed, after
second release() mozilla would be crashed.

Suggested fix:
call NS_ADDREF for newly created PlugletInstance in
Pluglet::CreatePlugletInstance

Comment 2

[Igor Kushnirskiy]

Attachment: fix for this bug

Comment 3

[Igor Kushnirskiy]

Akhil Arora has reviewed my changes.
As module owner, I will check them in.

Comment 4

[leger]

Adding crash keyword

Comment 5

[Vladimir Strigun]

Verified with Mozilla 0.9.5 (Mozilla/5.0 (Windows; U; WinNT4.0; en-US; 
rv:0.9.5+) Gecko/20011030). 
Mozilla do not crashed after reload.

Comment 6

[Alexei V. Mokeev]

VERIFIED