Closed Bug 163104 Opened 22 years ago Closed 22 years ago

Long lists of folders/bookmarks down arrow does not work correctly

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2beta

People

(Reporter: RainerBielefeldNG, Assigned: bugs)

References

Details

(Keywords: access, regression)

Attachments

(1 file, 1 obsolete file)

cvs diff this time
801 bytes, patch
deanis74
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review 
Bug 124485 is back again with
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1b) Gecko/20020815
(no problem until build 20020813)

Steps to reproduce:
1. open Bookmarks
2. open bookmark-subfolder with many entries
3. try to scroll down with mouse by "down-arrow"
   expected: list scrolls
   actual: list only scrolls 1 line any mouseclick
Keywords: access, regression
seeing a similar thing on Linux; mousing over the down-arrow at bottom of
bookmarks dropdown menu will scroll some lines, then stop. When i mouse over a
bookmark and back to arrow, it scrolls two more lines, then stop.
CVS from today.
can't find any clear dup - resolving as new.
OS/Platform All (guessing it affects more than just Windows and Linux.)
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 98 → All
Hardware: PC → All
Sounds like bug 62377.
Problme still exists in
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.1b) Gecko/20020818
It's not only a 1-day-fly
Depends on: 62377
Have noticed this problem since build on 20020810.
The previous build I was using was 20020727 and didn't have any problems
scrolling down in bookmarks.

Scrolling down using keys is ok and scrolling up works as well.
We're still experiencing this bug, using build 1.1b, 2002-08-26, with Linux
This problem still occurs in 20020907.
Severity: normal → major
Target Milestone: --- → mozilla1.2alpha
Behavior similar to the bug description seems to also happen on 1.2alpha
release, Linux version. 
The scrolling arrow problem still occurs on 1.2 alpha for windows (Build Id:
2002091014)
This bug also occurs when trying to scroll the main bookmark menu if it is
sufficiently populated, not just sub-folders of the bookmark menu. Confirmed
this on 1.2a (20020914) for Win32 and Solaris.
*** Bug 168134 has been marked as a duplicate of this bug. ***
I know what is wrong with this, fix should follow.
Attached patch two line fix for bookmark scrolling bug (obsolete) — — Splinter Review 
This is a two line fix.

The problem is in the code that finds out which index we have scrolled to in a
scrollableView.  The current code uses the bottom right hand corner of each
element, which makes it sensitive to rounding errors.  

The patch switches to using the center of the elements.
Attached patch cvs diff this time — — Splinter Review 
This new patch is made using "cvs diff -u", and should be more usable.

Code changes are the same.  Sorrry about the previous patch, but I am new here.
Attachment #99648 - Attachment is obsolete: true
I can't add the keywords patch and review.

Someone should add the keyword patch, to indicate the patch was written by
someone without check in rights(me).

Someone should add the keyword review, since I believe this patch to be ready
for review.

More important: I am requesting r/sr, and pending that checkin.
*** Bug 168895 has been marked as a duplicate of this bug. ***
*** Bug 169098 has been marked as a duplicate of this bug. ***
Adding keywords for adrian.
Keywords: patch, review
I'm not sure, but I believe bug 169607 could be related to this bug. This
problem just recently started happening too.

- Adam
*** Bug 169660 has been marked as a duplicate of this bug. ***
*** Bug 169607 has been marked as a duplicate of this bug. ***
*** Bug 169791 has been marked as a duplicate of this bug. ***
adrian i recommend emailing the people on the reviewers list
http://www.mozilla.org/hacking/reviewers.html to get reviews. Or bugging them on
irc.
Target Milestone: mozilla1.2alpha → mozilla1.2beta
*** Bug 170608 has been marked as a duplicate of this bug. ***
bug is still there

Mozilla 1.2b
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20020920


adding Bryner to cc list.

Bryner would you review this patch?  You are the person that reviewed the last
few changes to the file.

The patch is small and is explained in comment #13

If you are the wrong person to ask, could you point me to the correct person?
thanks!

Re comment #23:  According linked documents I need peer review before I can ask
for super review via the reviewers list.
Adrian, can you verify the original behavior without this patch, and does this
patch for sure fix it?  I'm having trouble replicating the original problem.
>Adrian, can you verify the original behavior without this patch, and does this
>patch for sure fix it?  

Scrolling of the bookmarks is broken in the latest nightlys, and for months back.

See the eight dupes(there are more sub dupes) and comments #1 #2 #4 #5 #6 #7 #9
#10 #25

Bug 62377 is the same bug and comments 12 13 16 18 19 23 27 29 all report this
problem.  There are two open bugs about this behavior, 12 votes for these bugs.

Yes it is still broken.  Yes this patch fixes it.

>I'm having trouble replicating the original problem.
See comment #1 in this bug and comment #15 in bug 62377 (Phil did a very good
job of describing this problem over there.)

Let me see if I can give directions that you can follow for replicating the bug.
1. launch mozilla
2. click on bookmarks
3. click on manange bookmarks.
4. fill up your bookmarks main menu by clicking on New Separator ~100 times.
(or a submenu, make sure to have a mix of bookmarks and separators)
5. navigate to the menu that you filled up.
6. place your mouse over the down arrow.
7. observe that the bookmark menu begins to scroll down, and then stops.
8. The menus down arrow is now completly broken, clicking or mousing out/in does
nothing.
(you can get it to move down one by highlighting/unhighlighting the lowest
bookmark, but this method of moving works without ever mousing over the down
arrow.  This method is a true pain)

If you still cannot see this bug, try looking at some of the directions in the
dupes.


So how does this patch fix the problem?

The problem is in the code that discovers how many elements have been scrolled
past.  It uses the bottom righthand corner of the each element and sees if we
have scrolled past that corner.  When it detects the corner as being past the
scrolled to point it thinks that we have scrolled to this index in the menu. 
When going down it then scrolls to the index+1 element, however sometimes the
code thinks that we have scrolled to the index-1 element(index-1+1=index)
therefore we scroll nowhere.  

The patch makes the index discovery code calculate the correct index.  It does
this by using the middle of the elements, removing the possiblity of pixel round
offs creating index off by one errors.  No index off by one errors means that we
scroll correctly.

Other solutions:
1. use the top of the elements  
   Rejected: this would break scrolling up.
2. Scroll by twos, so when off by one we still scroll albeit by one or by three.
   Rejected: other users of this code would get buggy scroll results.
   However there are currently no other users of this code, making my patch low 
   risk.
3. Ensure there is never an off by one or rounding of pixel values
   Rejected: impossible.
Comment on attachment 99692 [details] [diff] [review]
cvs diff this time

Thanks for the thorough explanation.

r=me
Attachment #99692 - Flags: review+
*** Bug 171444 has been marked as a duplicate of this bug. ***
*** Bug 171622 has been marked as a duplicate of this bug. ***
*** Bug 171817 has been marked as a duplicate of this bug. ***
*** Bug 171829 has been marked as a duplicate of this bug. ***
*** Bug 171860 has been marked as a duplicate of this bug. ***
removing self from spam list ... err cc list
oops, note to self: click not only e-mail, but checkbox underneath to remove
*** Bug 151892 has been marked as a duplicate of this bug. ***
*** Bug 172168 has been marked as a duplicate of this bug. ***
*** Bug 172441 has been marked as a duplicate of this bug. ***
This bug has r= since nearly one week.

Anybody to sr.

This is a very visible and annoying bug.
*** Bug 172654 has been marked as a duplicate of this bug. ***
*** Bug 172837 has been marked as a duplicate of this bug. ***
adrian: Please write a mail directly to a correct reviewer. CC is not the
correct way.

Matti: I emailed ben, hyatt, and bryner last week for an sr.  Anyone else care
to sr?  blake?  hewitt?
*** Bug 173273 has been marked as a duplicate of this bug. ***
Comment on attachment 99692 [details] [diff] [review]
cvs diff this time

sr=jag
Attachment #99692 - Flags: superreview+
timeless checked this in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 62377 has been marked as a duplicate of this bug. ***
verified using 2002100908 on WinXP.
Status: RESOLVED → VERIFIED
*** Bug 173714 has been marked as a duplicate of this bug. ***
*** Bug 173738 has been marked as a duplicate of this bug. ***
*** Bug 171996 has been marked as a duplicate of this bug. ***
bug  is fixed in

Mozilla 1.2b
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021009

thanks
*** Bug 174313 has been marked as a duplicate of this bug. ***
*** Bug 174825 has been marked as a duplicate of this bug. ***
*** Bug 174817 has been marked as a duplicate of this bug. ***
*** Bug 174861 has been marked as a duplicate of this bug. ***
*** Bug 175004 has been marked as a duplicate of this bug. ***
*** Bug 174909 has been marked as a duplicate of this bug. ***
Judging on the amount of dup spam, I'd say a lot of people need to upgrade to
the latest build.

Removing myself, since this bug has been fixed.  Verified WinME 2002101308.
Bug has been fixed in Build 2002101303, so am removing name from list. Thanks to
all you programmers. 
Bug fixed, verified in Win2k Thanks to all you programmers ...  Removing from 
CC list.
*** Bug 174602 has been marked as a duplicate of this bug. ***
*** Bug 176147 has been marked as a duplicate of this bug. ***
Bug seems to be fixed in Mozilla 1.2b (Microsoft Windows Platform),
remove from the mail-list.
*** Bug 176471 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: