Closed
Bug 163334
Opened 22 years ago
Closed 20 years ago
remove old nav4rounding pref
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: dbaron, Assigned: domob)
Details
(Whiteboard: [whitebox][good first bug])
Attachments
(1 file, 2 obsolete files)
8.04 KB,
patch
|
dbaron
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
We should remove the old nav4rounding pref. It's implemented on Windows-only, has no UI, and was really just a transitional thing. See bug 159332.
Reporter | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Future
Updated•22 years ago
|
Whiteboard: [dev notes]
Updated•22 years ago
|
Whiteboard: [dev notes] → [whitebox]
Updated•20 years ago
|
Whiteboard: [whitebox] → [whitebox][good first bug]
Assignee | ||
Comment 1•20 years ago
|
||
I think this should remove all nav4pref code. (Or, you could say, I'm sure it removes some of it). Mozilla with this patch applied builds, and I'm currently submitting this attachment with it.
Attachment #169632 -
Flags: review?(dbaron)
Reporter | ||
Comment 2•20 years ago
|
||
Comment on attachment 169632 [details] [diff] [review] Removes nav4round-Pref You should also remove the entire PrefChanged function, kPrefCID, and the #include of nsIPref.h. (But with those changes added I think it's fine.)
Attachment #169632 -
Flags: review?(dbaron) → review-
Assignee | ||
Comment 3•20 years ago
|
||
Now without the whole PrefChanged-method (of course, if no RegisterCallback is there anymore, this method is superfluous...)
Attachment #169632 -
Attachment is obsolete: true
Attachment #169639 -
Flags: review?(dbaron)
Reporter | ||
Comment 4•20 years ago
|
||
Comment on attachment 169639 [details] [diff] [review] Fixed Patch > float app2dev, app2twip, scale; remove app2twip and scale as well and r=dbaron
Attachment #169639 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•20 years ago
|
||
Removed those local variables, too.
Attachment #169639 -
Attachment is obsolete: true
Attachment #169640 -
Flags: review?(dbaron)
Reporter | ||
Updated•20 years ago
|
Attachment #169640 -
Flags: review?(dbaron) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #169640 -
Flags: superreview?(jst)
Comment 6•20 years ago
|
||
Comment on attachment 169640 [details] [diff] [review] Removed locals r=jst
Attachment #169640 -
Flags: superreview?(jst) → superreview+
Comment 7•20 years ago
|
||
Daniel, I assume you want this checked in once the tree reopens?
Assignee | ||
Comment 8•20 years ago
|
||
Oh yes, please.
Updated•20 years ago
|
Assignee: dbaron → d
Status: ASSIGNED → NEW
Comment 9•20 years ago
|
||
Fixed for 1.8b.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•