Closed Bug 164385 Opened 22 years ago Closed 22 years ago

SetDirty() often uses uninitialized rv

Categories

(Core Graveyard :: History: Global, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: bugzilla)

References

()

Details

Attachments

(1 file)

found this with valgrind
if mSynctimer is non-null (after the first time SetDirty is called), then
do_CreateInstance is not called, but rv is still checked and SetDirty returns
failure if NS_FAILED(rv) is true.

this code came from bug 65862.
Keywords: patch, review
Comment on attachment 96535 [details] [diff] [review]
only check rv if do_CreateInstance is called

r=dbradley
Attachment #96535 - Flags: review+
Comment on attachment 96535 [details] [diff] [review]
only check rv if do_CreateInstance is called

thanks!
sr=alecf
Attachment #96535 - Flags: superreview+
*** Bug 165030 has been marked as a duplicate of this bug. ***
blaker, dbradley or alecf: could one of you check this patch in to CVS?  thanks
Keywords: review
Patch checked in
SetDirty() often uses uninitialized rv
Patch was checked in 40 days ago: 2002-11-13
Why is that bug status still marked NEW, not resolved?
It is one of twenty bugs blocking bug 179819
Because I forgot?
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: