166179 - oblong ico file not draw excactly

Status: RESOLVED DUPLICATE of bug 160975

(Core :: Graphics: ImageLib, defect)

Description

[Hidehiro Kozawa]

xoip.ico is oblong ico file.
acording to MS, ico file must be square.
but IE can draw oblong ico file.
xoip.ico is 62x64.
IE draw 62x64 xoip.ico exactly.
mozilla does not draw it exactly.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Which build are you using?  (Always say this, please!).  This was fixed recently...

Comment 2

[Hidehiro Kozawa]

sorry...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1b) Gecko/20020902
If it was fixed in more recently mozilla, It's dup...

I know that crash bug was fixed.
http://bugzilla.mozilla.org/show_bug.cgi?id=159256

but draw not exactly.
Look xoip.ico some icon editor or IE, You know mozilla does not draw it exactly.

Comment 3

[Boris Zbarsky [:bzbarsky]]

imagelib.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: the icon

attaching the icon here

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I believe a part of this bug is bug 160975

however... I think we should use the 32x32 version of the icon, which is
contained in this file as well...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

right, the patch on bug 160975 fixes this.

will look into the 32x32 issue now...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

right, the patch on bug 160975 fixes this.

will look into the 32x32 issue now... I actually meant 16x16 not 32x32

ok. I see the problem. if an icon with a high color depth comes before the first
16x16 icon, we're still using the high-color icon (high-color != 16bit in this case)

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

grrr. don't know what I was thinking... the file does not have a 16x16 version.
so our behaviour is probably ok, with the patch from bug 160975.

marking duplicate.

*** This bug has been marked as a duplicate of 160975 ***