Closed
Bug 166690
Opened 22 years ago
Closed 22 years ago
Remove Messages column in Subscribe.
Categories
(SeaMonkey :: MailNews: Message Display, defect, P4)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2alpha
People
(Reporter: stephend, Assigned: stephend)
Details
Attachments
(3 files, 4 obsolete files)
35.69 KB,
image/gif
|
Details | |
12.51 KB,
image/gif
|
Details | |
2.80 KB,
patch
|
janv
:
review+
sspitzer
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
Build ID: 2002-09-04-08, All OSs. Summary: Remove Messages column in Subscribe. Per the spec, we currently have the Messages column in Subscribe for News. The problem is, it doesn't do anything, and isn't planned for implementation anytime soon (correct me if I'm wrong). I've got a patch to rip it out.
Assignee | ||
Updated•22 years ago
|
Assignee | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
Assignee | ||
Comment 3•22 years ago
|
||
If it doesn't do anything, yes, please remove it. If there is any chance it might get implemented in the future, please file a separate bug so it can be tracked. Thanks.
Comment 5•22 years ago
|
||
you are right. news gets no love, and won't for a while. can you comment out the xul instead of removing it, refer to a new bug (or find the existing bug) for "implement message count in subscribe"? I think you should remove this splitter as well: <splitter class="tree-splitter"/> - <treecol id="messagesColumn" persist="hidden" label="&messagesHeader.label;" - sort="?TotalMessages"/>
Assignee | ||
Comment 6•22 years ago
|
||
Removes extraneous splitter, comments out code instead of removing it.
Attachment #97835 -
Attachment is obsolete: true
Assignee | ||
Comment 7•22 years ago
|
||
Sorry, this really is it.
Attachment #97844 -
Attachment is obsolete: true
Assignee | ||
Comment 8•22 years ago
|
||
The bug for implementing message counts is bug 38906. Do we want that in the comments of Subscribe.xul/Subscribe.dtd?
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•22 years ago
|
||
Attachment #97845 -
Attachment is obsolete: true
Assignee | ||
Comment 10•22 years ago
|
||
Attachment #97848 -
Attachment is obsolete: true
Comment 11•22 years ago
|
||
Comment on attachment 97850 [details] [diff] [review] Should be final, was tested on Classic/Modern, tree and flat view of Subscribe. r=varga
Attachment #97850 -
Flags: review+
Comment 12•22 years ago
|
||
Comment on attachment 97850 [details] [diff] [review] Should be final, was tested on Classic/Modern, tree and flat view of Subscribe. sr=sspitzer affects end users positively, has UI approval from jglick. thanks for cleaning up my mess, hammer.
Attachment #97850 -
Flags: superreview+
Comment 13•22 years ago
|
||
Comment on attachment 97850 [details] [diff] [review] Should be final, was tested on Classic/Modern, tree and flat view of Subscribe. a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #97850 -
Flags: approval+
Assignee | ||
Comment 14•22 years ago
|
||
Fix landed on the trunk. Thanks to all! QA over to Karen, because I won't QA my own fixes.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
QA Contact: stephend → huang
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.2alpha
Assignee | ||
Updated•22 years ago
|
QA Contact: huang → yulian
Comment 16•22 years ago
|
||
Using trunk build 20030218 on winxp, maco osx and linux this is fixed. Verified.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
Component: MailNews: Subscribe → MailNews: Message Display
QA Contact: esther → search
You need to log in
before you can comment on or make changes to this bug.
Description
•