166775 - Remove unused _IMPL_NS_APPSHELL defines

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Stephen Walker]

_IMPL_NS_APPSHELL & NS_APPSHELL are defined in a few places, but they don't do 
anything. nsappshell.h is even built anymore, it can be removed completely, 
nothing uses nsIDOMXPConnectFactory.h, it can be removed completely, and the 
function that uses NS_APPSHELL in nsICmdLineService.idl isn't ever called.

A large amount of mac prefix files can also be completely removed:
/modules/mpfilelocprovider/macbuild/mpfilelocPrefix.h
/modules/mpfilelocprovider/macbuild/mpfilelocPrefix_debug.h
/xpfe/appshell/macbuild/AppShellSharedPrefix_debug.h
/xpfe/appshell/macbuild/AppShellSharedPrefix.h
/xpfe/components/bookmarks/macbuild/BookmarksPrefix.h
/xpfe/components/bookmarks/macbuild/BookmarksPrefix_debug.h
/xpfe/components/directory/DirectoryPrefix.h
/xpfe/components/directory/DirectoryPrefix_debug.h
/xpfe/components/find/macbuild/FindComponentPrefix.h
/xpfe/components/find/macbuild/FindComponentPrefix_debug.h
/xpfe/components/history/macbuild/historyPrefix_debug.h
/xpfe/components/history/macbuild/historyPrefix.h
/xpfe/components/prefwindow/macbuild/prefwindowPrefix.h
/xpfe/components/prefwindow/macbuild/prefwindowPrefix_debug.h
/xpfe/components/regviewer/RegViewerPrefix.h
/xpfe/components/regviewer/RegViewerPrefix_debug.h
/xpfe/components/related/macbuild/RelatedPrefix_debug.h
/xpfe/components/related/macbuild/RelatedPrefix.h
/xpfe/components/search/macbuild/SearchPrefix_debug.h
/xpfe/components/search/macbuild/SearchPrefix.h
/xpfe/components/shistory/macbuild/shistoryPrefix_debug.h
/xpfe/components/shistory/macbuild/shistoryPrefix.h
/xpfe/components/download-manager/macbuild/DownloadManagerPrefix_debug.h
/xpfe/components/download-manager/macbuild/DownloadManagerPrefix.h

Comment 1

[Stephen Walker]

Attachment: patch

Comment 2

[hacker formerly known as [e-mail]]

-> XP Apps

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 97904 [details] [diff] [review]
patch

r=bryner

Comment 4

[timeless]

i'm not going to remove nsappshell.h yet, sorry, I need to find out why
cvsguess.cgi can't find it (bug 170505).

Comment 5

[Worcester12345]

(In reply to comment #4)
> i'm not going to remove nsappshell.h yet, sorry, I need to find out why
> cvsguess.cgi can't find it (bug 170505).

Now that you've found out, will it go?