167151 - [cocoa] need support for modeOpenMultiple for nsIFilePicker

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[(not reading, please use [e-mail] instead)]

[cocoa] need support for modeOpenMultiple for nsIFilePicker

you need to override ::GetFiles()

see http://bugzilla.mozilla.org/show_bug.cgi?id=121122 for the windows impl.

Comment 1

[Mike Pinkerton (not reading bugmail)]

-> dagley

Comment 2

[Steve Dagley]

Any rush on a Cocoa version of this?  AFAIK it's a request for mail/news to
allow selection of multiple attachments at once and since we don't have
mail/news in Chimera...

Comment 3

[Mike Pinkerton (not reading bugmail)]

no, but the carbon version might be nice.

Comment 4

[sairuh (rarely reading bugmail)]

how about for opening multiple files within the browser (eg, chimera)?

if that's possible, then each file would open in a separate browser window or
tab, depending on the user's prefs.

Comment 5

[Steve Dagley]

Since I don't report into Internet Technologies anymore this bug needs a new
owner -> saari

Comment 6

[saari (gone)]

pinkerton, might be nice or necessary?

Comment 7

[Simon Fraser [no longer active]]

It's pretty important (and easy).

Comment 8

[(not reading, please use [e-mail] instead)]

one place this makes a difference to the user is for bug #43015:
"Cannot add multiple attachment in Attach File dialog (mail compose)"

Comment 9

[Simon Fraser [no longer active]]

Attachment: Patch to nsFilePicker.mm/h

Comment 10

[Simon Fraser [no longer active]]

Attachment: Patch addressing comments

Patch addressing comments made in bug 167149.

Comment 11

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 119766 [details] [diff] [review]
Patch addressing comments

r=pink

+  NSURL *fileURL = [[NSURL alloc] initWithString:[thePanel filename]
relativeToURL:dirURL];

i remember (a year ago) in chimera we had problems with NSURL not being able to
handle certain things and freaking out so we had to abandon its use. Do you
remember why? I don't, nor does conrad, but i remember we couldn't keep using
them. *shrug*

Comment 12

[Simon Fraser [no longer active]]

Wasn't it the crashes with very long filenames or file paths? Since, in this
case, the NSURL is coming from the file picker, it should be safe to use directly.

Comment 13

[Mike Pinkerton (not reading bugmail)]

or maybe it was incorrectly formatted urls...either way, you're right, it
shouldn't be a worry here.

Comment 14

[Simon Fraser [no longer active]]

Fixed.