16804 - File op: fileMove logs inconsistent info to Install.log when successful

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 10/18/99 SeaMonkey build

1. From http://jimbob/trigger2.html, click drop-down button and select
   a_fileop_filemove.  Click Trigger case button.

startInstall("Acceptance: a_fileop_filemove", "acceptance", "1.1.1.1", 0);
f = getFolder("Program");
g = getFolder("Temporary");
addFile("fileop_filemove", "2.2.2.2", jarSrc, f, jarSrc, true);
fileSource = f + jarSrc;
fileTarget = g;
err1 = fileMove(fileSource, fileTarget);
logComment("Path to fileSource = " + fileSource);
logComment("Path to fileTarget = " + fileTarget);
logComment("fileMove returns = " + err1);

RESULT:
The installation is successful.  The Install.log returns:

---------------------------------------------------------------------------
http://jimbob/jars/a_fileop_filemove.xpi     --     10/19/1999 13:50:06
---------------------------------------------------------------------------

     Acceptance: a_fileop_filemove
     -----------------------------

     ** Path to fileSource = C:\Program Files\moz1018\x86rel\smrtupdt.txt
     ** Path to fileTarget = C:\TEMP\
     ** fileMove returns = 0
     Item [1/2]	Installing: C:\Program Files\moz1018\x86rel\smrtupdt.txt
     Item [2/2]	Move File: C:\TEMP\smrtupdt.txt to C:\TEMP\

     Install completed successfully
     Finished Installation  10/19/1999 13:50:11

EXPECTED RESULT:
The line in question is:
     Item [2/2]	Move File: C:\TEMP\smrtupdt.txt to C:\TEMP\

It seems that it should be similar to:
     Item [2/2]	Move File: C:\Program Files\moz1018\x86rel\smrtupdt.txt to
                           C:\TEMP\

Comment 1

[Sean Su]

I overhauled the fileop functions to better detect and deal with errors.  This
is now fixed.

Comment 2

[Jimmy Lee]

Build 1999-10-27-09-M11(WIN), 1999-10-27-08-M11(MAC), 1999-10-27-08-M11(LINUX)

Looks good.

Comment 3

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine