Closed Bug 168760 Opened 22 years ago Closed 11 years ago

NS_DECL_ISUPPORTS_INHERITED need only override QueryInterface

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE
Milestone:
Future

People

(Reporter: darin.moz, Unassigned)

References

(
URL
)

Details

(Keywords: helpwanted) 

it seems like most consumers of NS_DECL_ISUPPORTS_INHERITED should only override
QueryInterface.  what's the use of reimplementing AddRef and Release as calls to
the Super class's AddRef and Release.  why not just leave out the extra function
calls?
Well, clearly this should be an option.  Maybe the origanal authoer wanted to
allow the inherited class to do special addref/release functionality.  

This is a low hanging fruit to rid ourselves of two extra vtable entries in
layout/content.  

Any takers?

-> future.
Keywords: helpwanted
Target Milestone: --- → Future
Assignee: dougt → nobody
QA Contact: scc → xpcom
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.