168935 - Message filters dialog no longer have cancel/OK buttons

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[Jim Laurent]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2a) Gecko/20020915
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2a) Gecko/20020915

Can't exit the message filters dialog because there is no longer any Cancel or
OK button.  ESC also fails to close the window.

The latest build has a new "Run Now" button in the Message filters dialog that
appears to be taking the place of the OK button.

Reproducible: Always

Steps to Reproduce:
1. Open mail
2. Choose tools -> Mail filters
3. No OK or Cancel button is available.  Esc does not dismiss the window.

Actual Results:  
Can't close the Message filters dialog box.

Expected Results:  
There should be an OK and Cancel button.  ESC should also close the dialog box.

Comment 1

[Greg K.]

Jim, what theme are you using? Does it happen using both Modern and Classic?

Comment 2

[laurel]

Using sept 16 trunk: Yes, it's a problem in both modern and classic.  Even
though you can resize the dialog, the bottom row of buttons (OK/Cancel/Help)
doesn't appear as it does when resizing the dialog on other platforms.  Need
this fixed post-haste, since it's a difficult one to get out of, since force
quit doesn't appear to work -- must force via reboot/cmd+pwr.

Comment 3

[laurel]

Just installed today's trunk on linux -- buttons not available even on resize
dialog.  Regression on all platforms since last week.

Comment 4

[scottputterman]

The cancel/OK buttons were purposefully removed.    We will be adding a close
button.

Comment 5

[(not reading, please use [e-mail] instead)]

taking.  I'll add the close button.

would close be mac only?

Comment 6

[(not reading, please use [e-mail] instead)]

wait, we should be doing what the other windows / dialogs are doing.

does advanced search have a close button?  I might just have to change the 
flags I pass when opening the dialog.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: working on it, making filter list behave like search dialog

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch, make filter list non-modal dialog

Comment 9

[(not reading, please use [e-mail] instead)]

fixed.  filter list dialog is no longer modal.

Comment 10

[(not reading, please use [e-mail] instead)]

the filter log has the same problem.  working on it...

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: patch for view filter log

Comment 12

[laurel]

*** Bug 169915 has been marked as a duplicate of this bug. ***

Comment 13

[laurel]

OK using nov24 commercial trunk